9775 launch config with instance store #9810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 18, 2019 14:42
* this revers part of commit 3d330bd, re-enabling the ability to use instance-store volumes * fetchRootDeviceName() will again return `nil, nil` when used against instance-store AMIs * re-add the `nil` value checking to fetchRootDeviceName() usage in readBlockDeviceMappingsFromConfig()
* added instance store data AMI source * added basic acceptance test using this instance-store AMI
ghost
added
size/M
|
Ended up having to extract a list of tests, and then run them each individually. Several tests were re-run due to low availability of m1 instances in us-west-2; perhaps more of these should be moved to |
ghost
mentioned this pull request
nywilken
added
regression
|
Thank you for your work! Any chance to get some traction on this? This is something that we have run into more than once. I would love to get a proper fix in instead of having to do workarounds. |
bflad
added
the
regression
bflad
approved these changes
Feb 12, 2020
There was a problem hiding this comment.
Looks good to me, thank you so much for this fix and associated testing, @jc-asdf 🚀
New test prior to fix:
--- FAIL: TestAccAWSLaunchConfiguration_withInstanceStoreAMI (13.84s)
testing.go:640: Step 0 error: errors during apply:
Error: Instance store backed AMIs do not provide a root device name - Use an EBS AMI
Output from acceptance testing:
--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (19.05s)
--- PASS: TestAccAWSLaunchConfiguration_withInstanceStoreAMI (20.40s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (20.90s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (21.66s)
--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (21.67s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (29.41s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (34.32s)
--- PASS: TestAccAWSLaunchConfiguration_basic (35.35s)
--- PASS: TestAccAWSLaunchConfiguration_userData (37.26s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (37.48s)
--- PASS: TestAccAWSLaunchConfiguration_updateRootBlockDevice (39.25s)
--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (39.58s)
bflad
added a commit
that referenced
this pull request
Feb 12, 2020
bflad
added a commit
that referenced
this pull request
Feb 12, 2020
|
This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #9775
Release note for CHANGELOG:
Output from acceptance testing:
Two sections affected.
aws_launch_configuration:The
aws_instancetests are odd - no matter what I try, it keeps trying to make some of the test resources inus-east-1, which is not where the test AMIs are located. I've set and exportedAWS_DEFAULT_REGION=us-west-2, and set the region in the default aws configuration, etc... but no luck.I suspect I'm running into some variation of what's described in #8316 when running the
aws_instancetests. Running individually is working so far. Will attach a full list of the individual tests run.