Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_codebuild_project: Allow file_system_locations to be removed on Update #40842

Merged
merged 2 commits into from
Jan 9, 2025
Merged

r/aws_codebuild_project: Allow file_system_locations to be removed on Update #40842

merged 2 commits into from
Jan 9, 2025

Conversation

kamilturek
Copy link
Collaborator

Description

This PR fixes the aws_codebuild_project to allow the file_system_locations configuration to be removed on Update.

Relations

Closes #38888.

References

https://docs.aws.amazon.com/codebuild/latest/APIReference/API_UpdateProject.html

Output from Acceptance Testing

% make testacc PKG=codebuild ACCTEST_PARALLELISM=1 TESTARGS="-run=TestAccCodeBuildProject_fileSystemLocations"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/codebuild/... -v -count 1 -parallel 1  -run=TestAccCodeBuildProject_fileSystemLocations -timeout 360m
2025/01/08 16:48:54 Initializing Terraform AWS Provider...
=== RUN   TestAccCodeBuildProject_fileSystemLocations
=== PAUSE TestAccCodeBuildProject_fileSystemLocations
=== CONT  TestAccCodeBuildProject_fileSystemLocations
--- PASS: TestAccCodeBuildProject_fileSystemLocations (72.50s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/codebuild  78.406s

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codebuild Issues and PRs that pertain to the codebuild service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Jan 8, 2025
@kamilturek kamilturek marked this pull request as ready for review January 8, 2025 22:01
@kamilturek kamilturek requested a review from a team as a code owner January 8, 2025 22:01
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 9, 2025
@ewbankkit ewbankkit self-assigned this Jan 9, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 9, 2025
ewbankkit
ewbankkit approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCodeBuildProject_' PKG=codebuild ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/codebuild/... -v -count 1 -parallel 3  -run=TestAccCodeBuildProject_ -timeout 360m
2025/01/09 08:37:28 Initializing Terraform AWS Provider...
=== RUN   TestAccCodeBuildProject_basic
=== PAUSE TestAccCodeBuildProject_basic
=== RUN   TestAccCodeBuildProject_disappears
=== PAUSE TestAccCodeBuildProject_disappears
=== RUN   TestAccCodeBuildProject_tags
=== PAUSE TestAccCodeBuildProject_tags
=== RUN   TestAccCodeBuildProject_publicVisibility
=== PAUSE TestAccCodeBuildProject_publicVisibility
=== RUN   TestAccCodeBuildProject_badgeEnabled
=== PAUSE TestAccCodeBuildProject_badgeEnabled
=== RUN   TestAccCodeBuildProject_buildTimeout
=== PAUSE TestAccCodeBuildProject_buildTimeout
=== RUN   TestAccCodeBuildProject_queuedTimeout
=== PAUSE TestAccCodeBuildProject_queuedTimeout
=== RUN   TestAccCodeBuildProject_cache
=== PAUSE TestAccCodeBuildProject_cache
=== RUN   TestAccCodeBuildProject_description
=== PAUSE TestAccCodeBuildProject_description
=== RUN   TestAccCodeBuildProject_fileSystemLocations
=== PAUSE TestAccCodeBuildProject_fileSystemLocations
=== RUN   TestAccCodeBuildProject_sourceVersion
=== PAUSE TestAccCodeBuildProject_sourceVersion
=== RUN   TestAccCodeBuildProject_encryptionKey
=== PAUSE TestAccCodeBuildProject_encryptionKey
=== RUN   TestAccCodeBuildProject_Environment_environmentVariable
=== PAUSE TestAccCodeBuildProject_Environment_environmentVariable
=== RUN   TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
=== PAUSE TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
=== RUN   TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
=== PAUSE TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
=== RUN   TestAccCodeBuildProject_Environment_certificate
=== PAUSE TestAccCodeBuildProject_Environment_certificate
=== RUN   TestAccCodeBuildProject_Environment_registryCredential
=== PAUSE TestAccCodeBuildProject_Environment_registryCredential
=== RUN   TestAccCodeBuildProject_Logs_cloudWatchLogs
=== PAUSE TestAccCodeBuildProject_Logs_cloudWatchLogs
=== RUN   TestAccCodeBuildProject_Logs_s3Logs
=== PAUSE TestAccCodeBuildProject_Logs_s3Logs
=== RUN   TestAccCodeBuildProject_buildBatch
=== PAUSE TestAccCodeBuildProject_buildBatch
=== RUN   TestAccCodeBuildProject_buildBatchConfigDelete
=== PAUSE TestAccCodeBuildProject_buildBatchConfigDelete
=== RUN   TestAccCodeBuildProject_Source_gitCloneDepth
=== PAUSE TestAccCodeBuildProject_Source_gitCloneDepth
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_gitHub
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_gitHub
=== RUN   TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
=== RUN   TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SecondarySourcesVersions
=== PAUSE TestAccCodeBuildProject_SecondarySourcesVersions
=== RUN   TestAccCodeBuildProject_Source_insecureSSL
=== PAUSE TestAccCodeBuildProject_Source_insecureSSL
=== RUN   TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
=== RUN   TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
=== PAUSE TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
=== RUN   TestAccCodeBuildProject_SourceType_bitbucket
=== PAUSE TestAccCodeBuildProject_SourceType_bitbucket
=== RUN   TestAccCodeBuildProject_SourceType_codeCommit
=== PAUSE TestAccCodeBuildProject_SourceType_codeCommit
=== RUN   TestAccCodeBuildProject_SourceType_codePipeline
=== PAUSE TestAccCodeBuildProject_SourceType_codePipeline
=== RUN   TestAccCodeBuildProject_SourceType_gitHubEnterprise
=== PAUSE TestAccCodeBuildProject_SourceType_gitHubEnterprise
=== RUN   TestAccCodeBuildProject_SourceType_s3
=== PAUSE TestAccCodeBuildProject_SourceType_s3
=== RUN   TestAccCodeBuildProject_SourceType_noSource
=== PAUSE TestAccCodeBuildProject_SourceType_noSource
=== RUN   TestAccCodeBuildProject_SourceType_noSourceInvalid
=== PAUSE TestAccCodeBuildProject_SourceType_noSourceInvalid
=== RUN   TestAccCodeBuildProject_vpc
=== PAUSE TestAccCodeBuildProject_vpc
=== RUN   TestAccCodeBuildProject_windowsServer2019Container
=== PAUSE TestAccCodeBuildProject_windowsServer2019Container
=== RUN   TestAccCodeBuildProject_armContainer
=== PAUSE TestAccCodeBuildProject_armContainer
=== RUN   TestAccCodeBuildProject_linuxLambdaContainer
=== PAUSE TestAccCodeBuildProject_linuxLambdaContainer
=== RUN   TestAccCodeBuildProject_Artifacts_artifactIdentifier
=== PAUSE TestAccCodeBuildProject_Artifacts_artifactIdentifier
=== RUN   TestAccCodeBuildProject_Artifacts_encryptionDisabled
=== PAUSE TestAccCodeBuildProject_Artifacts_encryptionDisabled
=== RUN   TestAccCodeBuildProject_Artifacts_location
=== PAUSE TestAccCodeBuildProject_Artifacts_location
=== RUN   TestAccCodeBuildProject_Artifacts_name
=== PAUSE TestAccCodeBuildProject_Artifacts_name
=== RUN   TestAccCodeBuildProject_Artifacts_namespaceType
=== PAUSE TestAccCodeBuildProject_Artifacts_namespaceType
=== RUN   TestAccCodeBuildProject_Artifacts_overrideArtifactName
=== PAUSE TestAccCodeBuildProject_Artifacts_overrideArtifactName
=== RUN   TestAccCodeBuildProject_Artifacts_packaging
=== PAUSE TestAccCodeBuildProject_Artifacts_packaging
=== RUN   TestAccCodeBuildProject_Artifacts_path
=== PAUSE TestAccCodeBuildProject_Artifacts_path
=== RUN   TestAccCodeBuildProject_Artifacts_type
=== PAUSE TestAccCodeBuildProject_Artifacts_type
=== RUN   TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
=== PAUSE TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
=== RUN   TestAccCodeBuildProject_secondaryArtifacts
=== PAUSE TestAccCodeBuildProject_secondaryArtifacts
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_location
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_location
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_name
    project_test.go:2602: Currently no solution to allow updates on name attribute
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_name (0.00s)
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_path
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_path
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_packaging
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_packaging
=== RUN   TestAccCodeBuildProject_SecondaryArtifacts_type
=== PAUSE TestAccCodeBuildProject_SecondaryArtifacts_type
=== RUN   TestAccCodeBuildProject_SecondarySources_codeCommit
=== PAUSE TestAccCodeBuildProject_SecondarySources_codeCommit
=== RUN   TestAccCodeBuildProject_concurrentBuildLimit
=== PAUSE TestAccCodeBuildProject_concurrentBuildLimit
=== RUN   TestAccCodeBuildProject_fleet
=== PAUSE TestAccCodeBuildProject_fleet
=== CONT  TestAccCodeBuildProject_basic
=== CONT  TestAccCodeBuildProject_Artifacts_location
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_overrideArtifactName (0.91s)
=== NAME  TestAccCodeBuildProject_basic
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_basic (0.91s)
=== CONT  TestAccCodeBuildProject_fleet
=== CONT  TestAccCodeBuildProject_concurrentBuildLimit
=== NAME  TestAccCodeBuildProject_Artifacts_location
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_location (0.91s)
=== CONT  TestAccCodeBuildProject_SecondarySources_codeCommit
=== NAME  TestAccCodeBuildProject_fleet
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_fleet (0.19s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_type
=== NAME  TestAccCodeBuildProject_concurrentBuildLimit
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_concurrentBuildLimit (0.20s)
=== CONT  TestAccCodeBuildProject_Artifacts_path
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_path (0.20s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_packaging
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_packaging (0.18s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_path
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_path (0.19s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_artifactIdentifier (0.19s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_namespaceType
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_namespaceType (0.17s)
=== CONT  TestAccCodeBuildProject_secondaryArtifacts
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_secondaryArtifacts (0.19s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_location
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_location (0.19s)
=== CONT  TestAccCodeBuildProject_Artifacts_bucketOwnerAccess
--- PASS: TestAccCodeBuildProject_SecondaryArtifacts_type (19.52s)
=== CONT  TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondaryArtifacts_encryptionDisabled (0.19s)
=== CONT  TestAccCodeBuildProject_Artifacts_type
--- PASS: TestAccCodeBuildProject_SecondarySources_codeCommit (20.16s)
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SourceGitSubmodules_gitHubEnterprise (0.19s)
=== CONT  TestAccCodeBuildProject_SourceType_codePipeline
--- PASS: TestAccCodeBuildProject_Artifacts_bucketOwnerAccess (34.28s)
=== CONT  TestAccCodeBuildProject_SourceType_codeCommit
--- PASS: TestAccCodeBuildProject_SourceType_codePipeline (23.19s)
=== CONT  TestAccCodeBuildProject_Artifacts_encryptionDisabled
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_encryptionDisabled (0.20s)
=== CONT  TestAccCodeBuildProject_SourceType_bitbucket
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (BITBUCKET) not found
--- SKIP: TestAccCodeBuildProject_SourceType_bitbucket (0.19s)
=== CONT  TestAccCodeBuildProject_Artifacts_artifactIdentifier
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_artifactIdentifier (0.20s)
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_gitHub
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SourceReportBuildStatus_gitHub (0.19s)
=== CONT  TestAccCodeBuildProject_linuxLambdaContainer
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_linuxLambdaContainer (0.19s)
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (BITBUCKET) not found
--- SKIP: TestAccCodeBuildProject_SourceReportBuildStatus_bitbucket (0.19s)
=== CONT  TestAccCodeBuildProject_armContainer
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_armContainer (0.18s)
=== CONT  TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SourceReportBuildStatus_gitHubEnterprise (0.18s)
=== CONT  TestAccCodeBuildProject_windowsServer2019Container
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_windowsServer2019Container (0.19s)
=== CONT  TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SourceBuildStatus_gitHubEnterprise (0.19s)
=== CONT  TestAccCodeBuildProject_vpc
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_vpc (0.19s)
=== CONT  TestAccCodeBuildProject_Source_insecureSSL
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Source_insecureSSL (0.19s)
=== CONT  TestAccCodeBuildProject_SourceType_noSourceInvalid
--- PASS: TestAccCodeBuildProject_Artifacts_type (32.62s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesVersions
--- PASS: TestAccCodeBuildProject_SourceType_noSourceInvalid (8.26s)
=== CONT  TestAccCodeBuildProject_SourceType_noSource
--- PASS: TestAccCodeBuildProject_SourceType_codeCommit (22.45s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHubEnterprise (0.18s)
=== CONT  TestAccCodeBuildProject_SourceType_s3
--- PASS: TestAccCodeBuildProject_SourceType_noSource (25.37s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_gitHub (0.19s)
=== CONT  TestAccCodeBuildProject_SourceType_gitHubEnterprise
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB_ENTERPRISE) not found
--- SKIP: TestAccCodeBuildProject_SourceType_gitHubEnterprise (0.18s)
=== CONT  TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit
--- PASS: TestAccCodeBuildProject_SourceType_s3 (22.08s)
=== CONT  TestAccCodeBuildProject_Artifacts_overrideArtifactName
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_overrideArtifactName (0.18s)
=== CONT  TestAccCodeBuildProject_Artifacts_packaging
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_packaging (0.19s)
=== CONT  TestAccCodeBuildProject_Artifacts_namespaceType
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_namespaceType (0.19s)
=== CONT  TestAccCodeBuildProject_Environment_environmentVariable
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Environment_environmentVariable (0.19s)
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_gitHub
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_SourceGitSubmodules_gitHub (0.18s)
=== CONT  TestAccCodeBuildProject_SourceGitSubmodules_codeCommit
--- PASS: TestAccCodeBuildProject_SecondarySourcesVersions (44.03s)
=== CONT  TestAccCodeBuildProject_queuedTimeout
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_queuedTimeout (0.19s)
=== CONT  TestAccCodeBuildProject_Source_gitCloneDepth
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Source_gitCloneDepth (0.18s)
=== CONT  TestAccCodeBuildProject_buildBatchConfigDelete
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_buildBatchConfigDelete (0.19s)
=== CONT  TestAccCodeBuildProject_encryptionKey
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_encryptionKey (0.19s)
=== CONT  TestAccCodeBuildProject_buildBatch
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_buildBatch (0.19s)
=== CONT  TestAccCodeBuildProject_sourceVersion
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_sourceVersion (0.19s)
=== CONT  TestAccCodeBuildProject_Logs_s3Logs
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Logs_s3Logs (0.18s)
=== CONT  TestAccCodeBuildProject_fileSystemLocations
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_fileSystemLocations (0.20s)
=== CONT  TestAccCodeBuildProject_description
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_description (0.22s)
=== CONT  TestAccCodeBuildProject_Logs_cloudWatchLogs
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Logs_cloudWatchLogs (0.19s)
=== CONT  TestAccCodeBuildProject_cache
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_cache (0.34s)
=== CONT  TestAccCodeBuildProject_Environment_registryCredential
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Environment_registryCredential (0.19s)
=== CONT  TestAccCodeBuildProject_publicVisibility
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_publicVisibility (0.21s)
=== CONT  TestAccCodeBuildProject_Environment_certificate
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Environment_certificate (0.21s)
=== CONT  TestAccCodeBuildProject_buildTimeout
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_buildTimeout (0.18s)
=== CONT  TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_EnvironmentEnvironmentVariable_value (0.19s)
=== CONT  TestAccCodeBuildProject_badgeEnabled
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_badgeEnabled (1.92s)
=== CONT  TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_EnvironmentEnvironmentVariable_type (0.19s)
=== CONT  TestAccCodeBuildProject_tags
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_tags (2.00s)
=== CONT  TestAccCodeBuildProject_disappears
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_disappears (0.19s)
=== CONT  TestAccCodeBuildProject_Artifacts_name
    source_credential_test.go:144: skipping acceptance testing: Source Credentials (GITHUB) not found
--- SKIP: TestAccCodeBuildProject_Artifacts_name (0.22s)
--- PASS: TestAccCodeBuildProject_SourceGitSubmodules_codeCommit (31.10s)
--- PASS: TestAccCodeBuildProject_SecondarySourcesGitSubmodules_codeCommit (36.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codebuild	122.367s

@ewbankkit
Copy link
Contributor

@kamilturek Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit e51b2d0 into hashicorp:main Jan 9, 2025
55 checks passed
@github-actions github-actions bot added this to the v5.83.0 milestone Jan 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 9, 2025
@kamilturek kamilturek deleted the b-aws-codebuild-project-file-system-locations-remove-on-update branch January 10, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
bug Addresses a defect in current functionality. external-maintainer Contribution from a trusted external contributor. service/codebuild Issues and PRs that pertain to the codebuild service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.83.0
Development

Successfully merging this pull request may close these issues.

[Bug]: file_system_locations cannot be removed from aws_codebuild_project
2 participants
@kamilturek @ewbankkit