-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/rds_certificate: add default_for_new_launches
attribute
#40536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
documentation
Introduces or discusses updates to documentation.
service/rds
Issues and PRs that pertain to the rds service.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
labels
Dec 11, 2024
github-actions
bot
added
the
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
label
Dec 23, 2024
ewbankkit
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRDSCertificateDataSource_' PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20 -run=TestAccRDSCertificateDataSource_ -timeout 360m
2024/12/23 13:54:10 Initializing Terraform AWS Provider...
=== RUN TestAccRDSCertificateDataSource_id
=== PAUSE TestAccRDSCertificateDataSource_id
=== RUN TestAccRDSCertificateDataSource_latestValidTill
=== PAUSE TestAccRDSCertificateDataSource_latestValidTill
=== RUN TestAccRDSCertificateDataSource_defaultForNewLaunches
=== PAUSE TestAccRDSCertificateDataSource_defaultForNewLaunches
=== CONT TestAccRDSCertificateDataSource_id
=== CONT TestAccRDSCertificateDataSource_defaultForNewLaunches
=== CONT TestAccRDSCertificateDataSource_latestValidTill
--- PASS: TestAccRDSCertificateDataSource_latestValidTill (9.48s)
--- PASS: TestAccRDSCertificateDataSource_defaultForNewLaunches (9.48s)
--- PASS: TestAccRDSCertificateDataSource_id (9.52s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 15.180s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
service/rds
Issues and PRs that pertain to the rds service.
tests
PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When set, the
default_for_new_launches
attribute will return the certificate that is set as default.Relations
References
Output from Acceptance Testing