Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/rds_certificate: add default_for_new_launches attribute #40536

Merged
merged 7 commits into from
Dec 23, 2024

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Dec 11, 2024

Description

When set, the default_for_new_launches attribute will return the certificate that is set as default.

Relations

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccRDSCertificateDataSource_\|TestAccRDSCluster_availabilityZones_caCertificateIdentifier' PKG=rds

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSCertificateDataSource_\|TestAccRDSCluster_availabilityZones_caCertificateIdentifier -timeout 360m
2024/12/23 09:54:59 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSCertificateDataSource_id
=== PAUSE TestAccRDSCertificateDataSource_id
=== RUN   TestAccRDSCertificateDataSource_latestValidTill
=== PAUSE TestAccRDSCertificateDataSource_latestValidTill
=== RUN   TestAccRDSCertificateDataSource_defaultForNewLaunches
=== PAUSE TestAccRDSCertificateDataSource_defaultForNewLaunches
=== RUN   TestAccRDSCluster_availabilityZones_caCertificateIdentifier
=== PAUSE TestAccRDSCluster_availabilityZones_caCertificateIdentifier
=== CONT  TestAccRDSCertificateDataSource_id
=== CONT  TestAccRDSCertificateDataSource_defaultForNewLaunches
=== CONT  TestAccRDSCertificateDataSource_latestValidTill
=== CONT  TestAccRDSCluster_availabilityZones_caCertificateIdentifier
--- PASS: TestAccRDSCertificateDataSource_latestValidTill (9.61s)
--- PASS: TestAccRDSCertificateDataSource_defaultForNewLaunches (9.74s)
--- PASS: TestAccRDSCertificateDataSource_id (9.84s)
--- PASS: TestAccRDSCluster_availabilityZones_caCertificateIdentifier (1470.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	1477.413s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Dec 11, 2024
@johnsonaj johnsonaj marked this pull request as ready for review December 23, 2024 18:05
@johnsonaj johnsonaj requested a review from a team as a code owner December 23, 2024 18:05
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Dec 23, 2024
@ewbankkit ewbankkit self-assigned this Dec 23, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRDSCertificateDataSource_' PKG=rds
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/rds/... -v -count 1 -parallel 20  -run=TestAccRDSCertificateDataSource_ -timeout 360m
2024/12/23 13:54:10 Initializing Terraform AWS Provider...
=== RUN   TestAccRDSCertificateDataSource_id
=== PAUSE TestAccRDSCertificateDataSource_id
=== RUN   TestAccRDSCertificateDataSource_latestValidTill
=== PAUSE TestAccRDSCertificateDataSource_latestValidTill
=== RUN   TestAccRDSCertificateDataSource_defaultForNewLaunches
=== PAUSE TestAccRDSCertificateDataSource_defaultForNewLaunches
=== CONT  TestAccRDSCertificateDataSource_id
=== CONT  TestAccRDSCertificateDataSource_defaultForNewLaunches
=== CONT  TestAccRDSCertificateDataSource_latestValidTill
--- PASS: TestAccRDSCertificateDataSource_latestValidTill (9.48s)
--- PASS: TestAccRDSCertificateDataSource_defaultForNewLaunches (9.48s)
--- PASS: TestAccRDSCertificateDataSource_id (9.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rds	15.180s

@johnsonaj johnsonaj merged commit 300942d into main Dec 23, 2024
60 checks passed
@johnsonaj johnsonaj deleted the f-rds_certificate_default branch December 23, 2024 19:09
@github-actions github-actions bot added this to the v5.83.0 milestone Dec 23, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants