-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds metrics_config
to aws_lambda_event_source_mapping
#40322
Adds metrics_config
to aws_lambda_event_source_mapping
#40322
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Created a PR for this as it looked straight-forward enough, and something I'm looking to use. That said - I'm new to Go and to this project so please call out if I should be changing anything in here or am not following standards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @amardatar 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccLambdaEventSourceMapping_Kinesis_basic\|TestAccLambdaEventSourceMapping_SQS_metricsConfig' PKG=lambda
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run=TestAccLambdaEventSourceMapping_Kinesis_basic\|TestAccLambdaEventSourceMapping_SQS_metricsConfig -timeout 360m
2024/11/27 09:08:57 Initializing Terraform AWS Provider...
=== RUN TestAccLambdaEventSourceMapping_Kinesis_basic
=== PAUSE TestAccLambdaEventSourceMapping_Kinesis_basic
=== RUN TestAccLambdaEventSourceMapping_SQS_metricsConfig
=== PAUSE TestAccLambdaEventSourceMapping_SQS_metricsConfig
=== CONT TestAccLambdaEventSourceMapping_Kinesis_basic
=== CONT TestAccLambdaEventSourceMapping_SQS_metricsConfig
--- PASS: TestAccLambdaEventSourceMapping_Kinesis_basic (67.84s)
--- PASS: TestAccLambdaEventSourceMapping_SQS_metricsConfig (97.77s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lambda 103.267s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccLambdaEventSourceMapping_Kinesis_basic\|TestAccLambdaEventSourceMapping_SQS_metricsConfig' PKG=lambda
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run=TestAccLambdaEventSourceMapping_Kinesis_basic\|TestAccLambdaEventSourceMapping_SQS_metricsConfig -timeout 360m
2024/11/27 10:32:29 Initializing Terraform AWS Provider...
=== RUN TestAccLambdaEventSourceMapping_Kinesis_basic
=== PAUSE TestAccLambdaEventSourceMapping_Kinesis_basic
=== RUN TestAccLambdaEventSourceMapping_SQS_metricsConfig
=== PAUSE TestAccLambdaEventSourceMapping_SQS_metricsConfig
=== CONT TestAccLambdaEventSourceMapping_Kinesis_basic
=== CONT TestAccLambdaEventSourceMapping_SQS_metricsConfig
--- PASS: TestAccLambdaEventSourceMapping_Kinesis_basic (75.07s)
--- PASS: TestAccLambdaEventSourceMapping_SQS_metricsConfig (109.78s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lambda 116.254s
@amardatar Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.79.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds support for
metrics_config
in theaws_lambda_event_source_mapping
resource. Copied from the related issue:Announcement
Blog post
Affected Resource(s) and/or Data Source(s)
aws_lambda_event_source_mapping
Potential Terraform Configuration
Relations
Closes #40275
References
Docs for Event Source Mapping Metrics
API Reference for the EventSourceMappingMetricsConfig
Output from Acceptance Testing