Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new ephemeral resources: aws_secretsmanager_secret_version and aws_kms_secrets #40009

Merged
merged 20 commits into from
Nov 20, 2024

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Nov 4, 2024

Description

Relations

Relates #39988

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSecretsManagerSecretVersionEphemeral_basic' PKG=secretsmanager

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/secretsmanager/... -v -count 1 -parallel 20  -run=TestAccSecretsManagerSecretVersionEphemeral_basic -timeout 360m
2024/11/13 13:50:04 Initializing Terraform AWS Provider...
=== RUN   TestAccSecretsManagerSecretVersionEphemeral_basic
=== PAUSE TestAccSecretsManagerSecretVersionEphemeral_basic
=== CONT  TestAccSecretsManagerSecretVersionEphemeral_basic
--- PASS: TestAccSecretsManagerSecretVersionEphemeral_basic (13.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager	19.533s
% make testacc TESTARGS='-run=TestAccKMSSecretsEphemeral_basic' PKG=kms

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/kms/... -v -count 1 -parallel 20  -run=TestAccKMSSecretsEphemeral_basic -timeout 360m
2024/11/13 16:52:07 Initializing Terraform AWS Provider...
=== RUN   TestAccKMSSecretsEphemeral_basic
=== PAUSE TestAccKMSSecretsEphemeral_basic
=== CONT  TestAccKMSSecretsEphemeral_basic
--- PASS: TestAccKMSSecretsEphemeral_basic (12.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	19.082s

Copy link

github-actions bot commented Nov 4, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/kms Issues and PRs that pertain to the kms service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 4, 2024
@johnsonaj johnsonaj added the new-ephemeral-resource Introduces a new ephemeral resource. label Nov 4, 2024
@johnsonaj johnsonaj force-pushed the f-ephemeral_secretsmanager_kms branch from 28df786 to 45d7ada Compare November 5, 2024 17:34
@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Nov 13, 2024
@johnsonaj johnsonaj marked this pull request as ready for review November 20, 2024 16:51
@johnsonaj johnsonaj requested a review from a team as a code owner November 20, 2024 16:51
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked over this many times in the last while but probably still missed something! Anyway, LGTM 🎉

@YakDriver YakDriver self-assigned this Nov 20, 2024
@johnsonaj johnsonaj merged commit 96e7562 into main Nov 20, 2024
53 of 54 checks passed
@johnsonaj johnsonaj deleted the f-ephemeral_secretsmanager_kms branch November 20, 2024 21:06
@github-actions github-actions bot added this to the v5.77.0 milestone Nov 20, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Nov 20, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 21, 2024
Copy link

This functionality has been released in v5.77.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-ephemeral-resource Introduces a new ephemeral resource. service/kms Issues and PRs that pertain to the kms service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants