-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_api_gateway_rest_api: Correct set root_resource_id
on resource Read
#37040
Conversation
% make testacc TESTARGS='-run=TestAccAPIGatewayResource_' PKG=apigateway ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.2 test ./internal/service/apigateway/... -v -count 1 -parallel 20 -run=TestAccAPIGatewayResource_ -timeout 360m === RUN TestAccAPIGatewayResource_basic === PAUSE TestAccAPIGatewayResource_basic === RUN TestAccAPIGatewayResource_update === PAUSE TestAccAPIGatewayResource_update === RUN TestAccAPIGatewayResource_disappears === PAUSE TestAccAPIGatewayResource_disappears === RUN TestAccAPIGatewayResource_withSleep === PAUSE TestAccAPIGatewayResource_withSleep === CONT TestAccAPIGatewayResource_basic === CONT TestAccAPIGatewayResource_disappears === CONT TestAccAPIGatewayResource_withSleep === CONT TestAccAPIGatewayResource_update --- PASS: TestAccAPIGatewayResource_basic (24.50s) --- PASS: TestAccAPIGatewayResource_disappears (61.87s) --- PASS: TestAccAPIGatewayResource_withSleep (93.56s) --- PASS: TestAccAPIGatewayResource_update (124.28s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/apigateway 134.632s
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
This functionality has been released in v5.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Correctly sets
root_resource_id
for non-AWS API Gateway implementations.Relations
Closes #37007.
Relates #36445.
Output from Acceptance Testing