Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f-aws_elasticache_serverless_cache:supports-minimum for cache_usage_l… #36766

Conversation

nikhil-goenka
Copy link
Contributor

…imits

Description

Relations

Closes #36624

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

github-actions bot commented Apr 6, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/elasticache Issues and PRs that pertain to the elasticache service. labels Apr 6, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 6, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 8, 2024
int64planmodifier.RequiresReplace(),
},
},
"minimum": schema.Int64Attribute{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of add a validator for the constraint aws imposes? You can set a minimum limit from 1 GB. and

@johnsonaj johnsonaj self-assigned this Apr 12, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 12, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

make testacc TESTARGS='-run=TestAccElastiCacheServerlessCache_' PKG=elasticache 

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/elasticache/... -v -count 1 -parallel 20  -run=TestAccElastiCacheServerlessCache_ -timeout 360m
--- PASS: TestAccElastiCacheServerlessCache_basic (355.05s)
--- PASS: TestAccElastiCacheServerlessCache_disappears (362.51s)
--- PASS: TestAccElastiCacheServerlessCache_fullRedis (362.72s)
--- PASS: TestAccElastiCacheServerlessCache_full (362.82s)
--- PASS: TestAccElastiCacheServerlessCache_update (403.56s)
--- PASS: TestAccElastiCacheServerlessCache_basicRedis (448.02s)
--- PASS: TestAccElastiCacheServerlessCache_tags (460.50s)
--- PASS: TestAccElastiCacheServerlessCache_updatesc (797.10s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticache	803.048s

@johnsonaj
Copy link
Contributor

@nikhil-goenka thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 9222aea into hashicorp:main Apr 12, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.46.0 milestone Apr 12, 2024
@johnsonaj johnsonaj mentioned this pull request Apr 12, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 19, 2024
Copy link

This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
@nikhil-goenka nikhil-goenka deleted the f-aws_elasticache_serverless_cache-supports-minimum branch June 16, 2024 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: r/aws_elasticache_serverless_cache: Support minimum cache usage limits
4 participants