Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSK cluster UUID #33805

Merged
merged 6 commits into from
Oct 9, 2023
Merged

MSK cluster UUID #33805

merged 6 commits into from
Oct 9, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Oct 6, 2023

Description

Adds the cluster_uuid attribute.

Relations

Closes #28196.

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccKafkaServerlessCluster_basic\|TestAccKafkaCluster_basic\|TestAccKafkaClusterDataSource_basic' PKG=kafka ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/kafka/... -v -count 1 -parallel 2  -run=TestAccKafkaServerlessCluster_basic\|TestAccKafkaCluster_basic\|TestAccKafkaClusterDataSource_basic -timeout 360m
=== RUN   TestAccKafkaClusterDataSource_basic
=== PAUSE TestAccKafkaClusterDataSource_basic
=== RUN   TestAccKafkaCluster_basic
=== PAUSE TestAccKafkaCluster_basic
=== RUN   TestAccKafkaServerlessCluster_basic
=== PAUSE TestAccKafkaServerlessCluster_basic
=== CONT  TestAccKafkaClusterDataSource_basic
=== CONT  TestAccKafkaServerlessCluster_basic
--- PASS: TestAccKafkaServerlessCluster_basic (237.31s)
=== CONT  TestAccKafkaCluster_basic
--- PASS: TestAccKafkaCluster_basic (1722.04s)
--- PASS: TestAccKafkaClusterDataSource_basic (2563.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kafka	2568.713s

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/kafka Issues and PRs that pertain to the kafka service. size/M Managed by automation to categorize the size of a PR. labels Oct 6, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 6, 2023
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 6, 2023
@ewbankkit ewbankkit merged commit 0ae76fd into main Oct 9, 2023
50 checks passed
@ewbankkit ewbankkit deleted the f-aws_msk_cluster.cluster_uuid branch October 9, 2023 11:46
@github-actions github-actions bot added this to the v5.21.0 milestone Oct 9, 2023
github-actions bot pushed a commit that referenced this pull request Oct 9, 2023
@github-actions
Copy link

This functionality has been released in v5.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/kafka Issues and PRs that pertain to the kafka service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add msk cluster uuid as an output
1 participant