-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TechDebt]: provider/tags: allow generator to override aws service package #31742
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple notes
internal/generate/tags/README.md
Outdated
@@ -24,6 +24,7 @@ Some flags control generation a certain section of code, such as whether the gen | |||
| --- | --- | --- | --- | | |||
| `GetTag` | | Whether to generate GetTag | `-GetTag` | | |||
| `ListTags` | | Whether to generate ListTags | `-ListTags` | | |||
| `ServicePackage` | | AWS Go SDK package to use. Defaults to the provider service package name. | `-ServicePackage=chimesdkvoice` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `ServicePackage` | | AWS Go SDK package to use. Defaults to the provider service package name. | `-ServicePackage=chimesdkvoice` | | |
| `TagServicePackage` | | AWS Go SDK package to use. Defaults to the provider service package name. | `-TagServicePackage=chimesdkvoice` | |
Maybe? Seems like this will go away eventually and might be easier to extricate with this name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or AWSSDKServicePackage
to match AWSSDKVersion
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to AWSSDKServicePackage
and changed the logic around so the InternalServicePackage
field is no longer necessary. If we opt to back this out later it should only requiring removing the flag and reverting a couple function calls to use the servicePackage
variable again.
internal/generate/tags/main.go
Outdated
@@ -123,6 +124,7 @@ type TemplateData struct { | |||
AWSService string | |||
AWSServiceIfacePackage string | |||
ClientType string | |||
InternalServicePackage string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InternalServicePackage string | |
TagServicePackage string |
Similar to above
This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds an optional
-AWSSDKServicePackage
argument to the tags generator, allowing the AWS Go SDK package to be overridden. Specifically, this will support tagging in thechime
service package by allowing the tagging functions to use thechimesdkvoice
AWS SDK package which has proper tagging support unavailable in the legacychime
namespace.This PR will enable supporting
tags
for existingchime
resources once merged.Relations
Relates #27432
References