Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_kinesis_firehose_delivery_stream: deprecate root s3_configuration #31138

Merged
merged 14 commits into from
May 4, 2023
Merged

r/aws_kinesis_firehose_delivery_stream: deprecate root s3_configuration #31138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
36e4fb6
add s3_configuration to attributes
johnsonaj May 2, 2023
b330e37
s3_configuration in update func
johnsonaj May 3, 2023
db7086e
s3_configuration in read
johnsonaj May 3, 2023
7c5baff
arrange alphabetically
johnsonaj May 3, 2023
034057e
arrange alphabetically
johnsonaj May 3, 2023
acce44d
cleanup: remove test for s3 destination
johnsonaj May 3, 2023
82b1f91
test: check correct attribute locations
johnsonaj May 3, 2023
5b1742f
linter: fix acctest fmt
johnsonaj May 3, 2023
a4ab9f3
fmt
johnsonaj May 3, 2023
755dc69
add CHANGELOG entry
johnsonaj May 3, 2023
7728255
docs: update documentation
johnsonaj May 3, 2023
4a0dd95
linter: website lint fix
johnsonaj May 3, 2023
f122b0d
fix link in docs
johnsonaj May 3, 2023
b19ee4c
remove s3 destination constant
johnsonaj May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changelog/31138.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
```release-note:breaking-change
resource/aws_kinesis_firehose_delivery_stream: Remove `s3` as an option for `destination`. Use `extended_s3` instead
```

```release-note:breaking-change
resource/aws_kinesis_firehose_delivery_stream: Remove `s3_configuration` attribute from the root of the resource. `s3_configuration` is now a part of the following blocks: `elasticsearch_configuration`, `opensearch_configuration`, `redshift_configuration`, `splunk_configuration`, and `http_endpoint_configuration`
```

```release-note:enhancement
resource/aws_kinesis_firehose_delivery_stream: Add `s3_configuration` to `elasticsearch_configuration`, `opensearch_configuration`, `redshift_configuration`, `splunk_configuration`, and `http_endpoint_configuration`
```
Loading