Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_chime_voice_connector: add tagging support #31746

Merged
merged 3 commits into from
Jun 5, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Jun 2, 2023

Description

Adds tagging support for the legacy Chime Voice Connector resource.

Relations

Closes #27432
Closes #31302
Relates #31742
Closes #31272 (no longer required with transparent tagging support added to the chime namespace)

References

Output from Acceptance Testing

$ make testacc PKG=chime TESTS=TestAccChimeVoiceConnector_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chime/... -v -count 1 -parallel 20 -run='TestAccChimeVoiceConnector_'  -timeout 180m

--- PASS: TestAccChimeVoiceConnector_basic (14.27s)
--- PASS: TestAccChimeVoiceConnector_update (22.59s)
--- PASS: TestAccChimeVoiceConnector_disappears (23.56s)
--- PASS: TestAccChimeVoiceConnector_tags (30.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chime      33.956s

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. generators Relates to code generators. service/chime Issues and PRs that pertain to the chime service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 2, 2023
@jar-b jar-b force-pushed the f-aws_chime_voice_connector-tags branch from b5f15aa to c03150a Compare June 2, 2023 19:58
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jun 2, 2023
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccChimeVoiceConnector_' PKG=chime ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chime/... -v -count 1 -parallel 2  -run=TestAccChimeVoiceConnector_ -timeout 180m
=== RUN   TestAccChimeVoiceConnector_basic
=== PAUSE TestAccChimeVoiceConnector_basic
=== RUN   TestAccChimeVoiceConnector_disappears
=== PAUSE TestAccChimeVoiceConnector_disappears
=== RUN   TestAccChimeVoiceConnector_update
=== PAUSE TestAccChimeVoiceConnector_update
=== RUN   TestAccChimeVoiceConnector_tags
=== PAUSE TestAccChimeVoiceConnector_tags
=== CONT  TestAccChimeVoiceConnector_basic
=== CONT  TestAccChimeVoiceConnector_update
--- PASS: TestAccChimeVoiceConnector_basic (19.13s)
=== CONT  TestAccChimeVoiceConnector_disappears
--- PASS: TestAccChimeVoiceConnector_update (31.61s)
=== CONT  TestAccChimeVoiceConnector_tags
--- PASS: TestAccChimeVoiceConnector_disappears (13.95s)
--- PASS: TestAccChimeVoiceConnector_tags (39.96s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/chime	77.187s

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Jun 5, 2023
@jar-b
Copy link
Member Author

jar-b commented Jun 5, 2023

$ AWS_DEFAULT_REGION=us-east-1 AWS_REGION=us-east-1 make testacc PKG=chime TESTS=TestAccChimeVoiceConnector_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chime/... -v -count 1 -parallel 20 -run='TestAccChimeVoiceConnector_'  -timeout 180m

--- PASS: TestAccChimeVoiceConnector_disappears (12.00s)
--- PASS: TestAccChimeVoiceConnector_basic (15.48s)
--- PASS: TestAccChimeVoiceConnector_update (24.64s)
--- PASS: TestAccChimeVoiceConnector_tags (31.45s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/chime      35.063s

@jar-b jar-b merged commit b399c42 into main Jun 5, 2023
@jar-b jar-b deleted the f-aws_chime_voice_connector-tags branch June 5, 2023 14:57
@github-actions github-actions bot added this to the v5.2.0 milestone Jun 5, 2023
github-actions bot pushed a commit that referenced this pull request Jun 5, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/chime Issues and PRs that pertain to the chime service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants