-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_chime_voice_connector: add tagging support #31746
Conversation
Community NoteVoting for Prioritization
For Submitters
|
b5f15aa
to
c03150a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccChimeVoiceConnector_' PKG=chime ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chime/... -v -count 1 -parallel 2 -run=TestAccChimeVoiceConnector_ -timeout 180m
=== RUN TestAccChimeVoiceConnector_basic
=== PAUSE TestAccChimeVoiceConnector_basic
=== RUN TestAccChimeVoiceConnector_disappears
=== PAUSE TestAccChimeVoiceConnector_disappears
=== RUN TestAccChimeVoiceConnector_update
=== PAUSE TestAccChimeVoiceConnector_update
=== RUN TestAccChimeVoiceConnector_tags
=== PAUSE TestAccChimeVoiceConnector_tags
=== CONT TestAccChimeVoiceConnector_basic
=== CONT TestAccChimeVoiceConnector_update
--- PASS: TestAccChimeVoiceConnector_basic (19.13s)
=== CONT TestAccChimeVoiceConnector_disappears
--- PASS: TestAccChimeVoiceConnector_update (31.61s)
=== CONT TestAccChimeVoiceConnector_tags
--- PASS: TestAccChimeVoiceConnector_disappears (13.95s)
--- PASS: TestAccChimeVoiceConnector_tags (39.96s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/chime 77.187s
$ AWS_DEFAULT_REGION=us-east-1 AWS_REGION=us-east-1 make testacc PKG=chime TESTS=TestAccChimeVoiceConnector_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/chime/... -v -count 1 -parallel 20 -run='TestAccChimeVoiceConnector_' -timeout 180m
--- PASS: TestAccChimeVoiceConnector_disappears (12.00s)
--- PASS: TestAccChimeVoiceConnector_basic (15.48s)
--- PASS: TestAccChimeVoiceConnector_update (24.64s)
--- PASS: TestAccChimeVoiceConnector_tags (31.45s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/chime 35.063s |
This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds tagging support for the legacy Chime Voice Connector resource.
Relations
Closes #27432
Closes #31302
Relates #31742
Closes #31272 (no longer required with transparent tagging support added to the
chime
namespace)References
Output from Acceptance Testing