Skip to content

Commit

Permalink
Merge pull request #39928 from hashicorp/b-d/aws_imagebuilder_image_r…
Browse files Browse the repository at this point in the history
…ecipe

d/aws_imagebuilder_image_recipe: Fix `block_device_mapping.0.ebs.0.delete_on_termination: '' expected type 'bool', got unconvertible type 'string', value: 'true'`
  • Loading branch information
ewbankkit authored Oct 29, 2024
2 parents b2a257d + cdff4fe commit 63ff69b
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .changelog/39928.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
data-source/aws_imagebuilder_image_recipe: Fix `block_device_mapping.0.ebs.0.delete_on_termination: '' expected type 'bool', got unconvertible type 'string'` errors
```
5 changes: 3 additions & 2 deletions internal/service/imagebuilder/image_recipe_data_source.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/hashicorp/terraform-provider-aws/internal/conns"
"github.com/hashicorp/terraform-provider-aws/internal/errs/sdkdiag"
"github.com/hashicorp/terraform-provider-aws/internal/sdkv2/types/nullable"
tftags "github.com/hashicorp/terraform-provider-aws/internal/tags"
"github.com/hashicorp/terraform-provider-aws/internal/verify"
"github.com/hashicorp/terraform-provider-aws/names"
Expand Down Expand Up @@ -43,11 +44,11 @@ func dataSourceImageRecipe() *schema.Resource {
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
names.AttrDeleteOnTermination: {
Type: schema.TypeBool,
Type: nullable.TypeNullableBool,
Computed: true,
},
names.AttrEncrypted: {
Type: schema.TypeBool,
Type: nullable.TypeNullableBool,
Computed: true,
},
names.AttrIOPS: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ resource "aws_imagebuilder_component" "test" {
}
resource "aws_imagebuilder_image_recipe" "test" {
block_device_mapping {
ebs {
delete_on_termination = true
}
}
component {
component_arn = aws_imagebuilder_component.test.arn
Expand Down

0 comments on commit 63ff69b

Please sign in to comment.