feat: Mark name arg as optional to match AWS API for aws_ram_resource_share data source #46169
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Dependency Checks | |
| on: | |
| push: | |
| branches: | |
| - main | |
| - 'release/**' | |
| pull_request_target: | |
| jobs: | |
| community_check: | |
| if: github.event_name == 'pull_request_target' | |
| uses: ./.github/workflows/community-check.yml | |
| secrets: inherit | |
| with: | |
| username: ${{ github.event.pull_request.user.login }} | |
| changes: | |
| needs: community_check | |
| name: Filter Changes | |
| runs-on: ubuntu-latest | |
| outputs: | |
| changed: ${{ steps.filter.outputs.changed }} | |
| steps: | |
| - uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2 | |
| if: needs.community_check.outputs.maintainer == 'false' | |
| id: filter | |
| with: | |
| filters: | | |
| changed: | |
| - .ci/providerlint/** | |
| - go.mod | |
| - go.sum | |
| comment: | |
| needs: changes | |
| if: needs.changes.outputs.changed == 'true' | |
| name: Comment | |
| runs-on: ubuntu-latest | |
| steps: | |
| - name: Find Existing PR Comment | |
| id: prc | |
| uses: peter-evans/find-comment@d5fe37641ad8451bdd80312415672ba26c86575e # v3.0.0 | |
| with: | |
| issue-number: ${{ github.event.pull_request.number }} | |
| comment-author: "github-actions[bot]" | |
| body-includes: "Please note that typically Go dependency changes" | |
| - run: echo ${{ steps.prc.outputs.comment-id }} | |
| - name: PR Comment | |
| if: steps.prc.outputs.comment-id == '' | |
| uses: peter-evans/create-or-update-comment@71345be0265236311c031f5c7866368bd1eff043 # v4.0.0 | |
| env: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| with: | |
| issue-number: ${{ github.event.pull_request.number }} | |
| body: |- | |
| Thank you for your contribution! :rocket: | |
| Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the `go.mod` or `go.sum` files and commit them into this pull request. | |
| Additional details: | |
| * Check [open pull requests with the `dependencies` label](https://github.com/hashicorp/terraform-provider-aws/pulls?q=is%3Aopen+is%3Apr+label%3Adependencies) to view other dependency updates. | |
| * If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed. | |
| * If this pull request is for supporting a new AWS service: | |
| * Ensure the new AWS service changes are following the [Contributing Guide section on new services](https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/add-a-new-service.md), in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split. | |
| * If this pull request is already a separate pull request from the above item, you can ignore this message. | |
| go_mod: | |
| name: go mod | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2 | |
| - uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0 | |
| with: | |
| go-version-file: .go-version | |
| - name: go mod | |
| run: | | |
| gover=go`cat .go-version | xargs` | |
| go install golang.org/dl/${gover}@latest | |
| ${gover} download | |
| echo "Using make to check dependencies" | |
| make depscheck |