-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance #96
Maintenance #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nitpicky comments on the latest stable version, but I'll leave it up to you to decide whether or not to address them. LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few thoughts!
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [hashicorp/setup-packer](https://togithub.com/hashicorp/setup-packer) | action | minor | `v3.0.0` -> `v3.1.0` | --- ### Release Notes <details> <summary>hashicorp/setup-packer (hashicorp/setup-packer)</summary> ### [`v3.1.0`](https://togithub.com/hashicorp/setup-packer/releases/tag/v3.1.0) [Compare Source](https://togithub.com/hashicorp/setup-packer/compare/v3.0.0...v3.1.0) ##### What's Changed - Maintenance by [@​ksatirli](https://togithub.com/ksatirli) in [https://github.com/hashicorp/setup-packer/pull/96](https://togithub.com/hashicorp/setup-packer/pull/96) - Bump [@​hashicorp/github-actions-core](https://togithub.com/hashicorp/github-actions-core) from 1.0.0 to v1.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/hashicorp/setup-packer/pull/97](https://togithub.com/hashicorp/setup-packer/pull/97) - Bump follow-redirects from 1.15.5 to 1.15.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/hashicorp/setup-packer/pull/94](https://togithub.com/hashicorp/setup-packer/pull/94) ##### New Contributors - [@​dependabot](https://togithub.com/dependabot) made their first contribution in [https://github.com/hashicorp/setup-packer/pull/97](https://togithub.com/hashicorp/setup-packer/pull/97) **Full Changelog**: hashicorp/setup-packer@v3.0.0...v3.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/packer-plugin-hcloud). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Hello maintainers 👋🏼
This PR carries out some package maintenance and updates some of the examples.
I've also trimmed down
dependencies
inpackage.json
and removed dependencies that are actually handled upstream ingithub-actions-core
.For testing purposes, I created an experimental tag, and used this here.
Conclusions:
Local execution test:
Once approved, I'd like to release this as
3.1.0
.