call evict on replacing value

[dongnguyenvt]

No description provided.

[hashicorp-cla]

All committers have signed the CLA.

[dongnguyenvt]

there is an alternative way that use the lru.ContainsOrAdd interface and check exist boolean return

[karwinliu]

curious why onEvict needs to be called when adding an existing item?
This caused issue in our use case, where we used gRPC channel as ent.value, and onEvict will close the channel unexpectedly if we try to add that existing channel again

[dongnguyenvt]

I'll leave it for maintainers of this project to make the call

• the value is dropped from cache, and some projects rely on evict callback to cleanup (cgo project will also free memory), in some race condition it can cause memory leak and hard to trace
• in your usecase you can use the somewhat side-effect free ContainsOrAdd

p/s: not sure why you adding back grpc connection to the cache that you just picked from

[karwinliu]

I understand using evict when item is dropped from cache. But in this code block, why do we need to drop from cache? Isn't c.evictList.moveToFront(ent) is enough and the item should still be kept in the cache?

[dongnguyenvt]

you can see right after that the value is overrided with new value, so old value is drop, in your usecase it seems both values are same

[karwinliu]

I see, this behavior came as a surprise for us, as we had a large cache size and didn't expect evict callback to be triggered. Anyways, we can use something like ContainsOrAdd as you suggested

[jefferai]

Thank you!