Redacted URL in logs / errors #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that basic auth creds, if any, won't show up in logs
|
|
dany74q
commented
Mar 16, 2022
manicminer
approved these changes
May 30, 2024
|
Hey @dany74q - we've decided to retroactively issue a CVE for this issue. If you would like credit for the discovery or fix, please email security[at]hashicorp.com with the name/identifier you would like us to use (Github user dany74q, Dany from SomeCompany, etc.) An acknowledgement will be included in a security bulletin published to https://discuss.hashicorp.com/c/security/ Thank you again! |
danishprakash
pushed a commit
to SUSE/podman
that referenced
this pull request
Oct 1, 2024
This is hashicorp/go-retryablehttp#158 only directly applied to the vendor/ source tree See also GHSA-v6v8-xj6m-xwqh
danishprakash
pushed a commit
to danishprakash/podman
that referenced
this pull request
Oct 3, 2024
This is hashicorp/go-retryablehttp#158 only directly applied to the vendor/ source tree See also GHSA-v6v8-xj6m-xwqh
dcermak
pushed a commit
to SUSE/go-retryablehttp
that referenced
this pull request
Dec 9, 2024
This is a cherry pick of three commits: 28e8f81 65e8765 b2aee50 - So that basic auth creds, if any, won't show up in logs - Apparently Redacted() was added in go 1.15 - Copied Redacted() implementation from go 1.15 All are taken from hashicorp#158 This fixes CVE-2024-6104 aka CVE-2024-6104 aka GHSA-v6v8-xj6m-xwqh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that basic auth creds, if any, won't show up in logs