-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add solo smoke test to test flow #905
Conversation
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
…solo-smoke-test Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/account.ts # src/commands/flags.ts
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
- Coverage 85.01% 84.98% -0.03%
==========================================
Files 71 71
Lines 19142 19221 +79
Branches 1631 1684 +53
==========================================
+ Hits 16273 16335 +62
+ Misses 2764 2730 -34
- Partials 105 156 +51
|
Signed-off-by: Jeffrey Tang <[email protected]>
…solo-smoke-test Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/account.ts # src/commands/flags.ts
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error handling needs to be fixed in the script. You have a test case error, but it ate the error and showed a success: https://github.com/hashgraph/solo/actions/runs/12238568891/job/34136963069?pr=905#step:9:518
This is the issue I mentioned before that with linux github runner, also there is a background thread kept re-enable port-forward. from log you can see results of
|
This is the same issue repeated on macOS line 285 we can see all port forwards are still active |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review applies to:
.github/workflows/flow-task-test.yaml
My point, is that the workflow should be showing a failure, but it is showing a success. |
What shown in the log is first try of test is failed due to port-forward is stopped, The workflow is passed because test success with the retry less than 5 times. |
Signed-off-by: Jeffrey Tang <[email protected]>
After some experiment from last night, I found if port-forward were called within Task, but if port-forward were called outside Task, they would be consistently working. I did not have an explanation for this.
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Jeromy Cannon <[email protected]>
that makes sense, thank you for the explanation, approved |
Description
This pull request changes the following:
generateEcdsaKey
so user can usesolo account create
to create account with auto generated ECDSA key, no need to provide a EDCSA key string to solocreateAmount
so solo can continuously generating many account, so we can use the feature to generate background transactions when testing relay node. Cannot use original standalonesolo account create
since it is too slow can only finish one account in about 9~10 secondssolo account get
commandRelated Issues