Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Setup mirror node monitor pinger service #893

Merged

Conversation

Ivo-Yankov
Copy link
Contributor

@Ivo-Yankov Ivo-Yankov commented Dec 2, 2024

Description

  • Adds a pinger boolean flag to solo mirror-node deploy that when set to true will setup a pinger service in the monitor. It will start generating CRYPTO_TRANSFER transactions from 0.0.2 to 0.0.55 and thus forcing a constant flow of record files. This fixes an issue where the latest transaction gets "stuck" and the mirror node does not import it until a newer one is created.
  • By default the Pinger is disabled. To enable it use solo mirror-node deploy --namespace {namespace} --pinger true
  • Changed the ordering of the parametters in chart_manager.ts -> upgrade to make it consistent with the install method

Related Issues

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Unit Test Results - Linux

  1 files  ±0   36 suites  ±0   4s ⏱️ -1s
109 tests ±0  109 ✅ ±0  0 💤 ±0  0 ❌ ±0 
118 runs  ±0  118 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8c04094. ± Comparison against base commit f7e62b4.

♻️ This comment has been updated with latest results.

Signed-off-by: Ivo Yankov <[email protected]>
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Unit Test Results - Windows

  1 files  ±0   36 suites  ±0   12s ⏱️ -2s
109 tests ±0  109 ✅ ±0  0 💤 ±0  0 ❌ ±0 
118 runs  ±0  118 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8c04094. ± Comparison against base commit f7e62b4.

♻️ This comment has been updated with latest results.

@Ivo-Yankov Ivo-Yankov changed the title Setup mirror node monitor pinger service feat: Setup mirror node monitor pinger service Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

E2E Test Report

 13 files  ±0   94 suites  ±0   54m 37s ⏱️ -38s
199 tests ±0  199 ✅ ±0  0 💤 ±0  0 ❌ ±0 
202 runs  ±0  202 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8c04094. ± Comparison against base commit f7e62b4.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

E2E Test Report

 13 files  ±0   94 suites  ±0   54m 37s ⏱️ -38s
199 tests ±0  199 ✅ ±0  0 💤 ±0  0 ❌ ±0 
202 runs  ±0  202 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8c04094. ± Comparison against base commit f7e62b4.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.06% (target: -1.00%) 94.44%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f7e62b4) 14906 12666 84.97%
Head commit (8c04094) 14962 (+56) 12722 (+56) 85.03% (+0.06%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#893) 36 34 94.44%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@Ivo-Yankov Ivo-Yankov self-assigned this Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.83%. Comparing base (f7e62b4) to head (8c04094).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/network.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
+ Coverage   83.82%   83.83%   +0.01%     
==========================================
  Files          49       49              
  Lines       14934    14962      +28     
  Branches     1076     1468     +392     
==========================================
+ Hits        12518    12544      +26     
+ Misses       2379     2274     -105     
- Partials       37      144     +107     
Files with missing lines Coverage Δ
src/commands/flags.ts 99.57% <100.00%> (+<0.01%) ⬆️
src/commands/mirror_node.ts 77.64% <100.00%> (+0.77%) ⬆️
src/commands/node/tasks.ts 84.75% <100.00%> (ø)
src/core/chart_manager.ts 85.27% <100.00%> (ø)
src/commands/network.ts 74.32% <0.00%> (ø)

... and 26 files with indirect coverage changes

Impacted file tree graph

@Ivo-Yankov Ivo-Yankov marked this pull request as ready for review December 2, 2024 11:10
@Ivo-Yankov Ivo-Yankov requested review from leninmehedy and a team as code owners December 2, 2024 11:10
@jeromy-cannon jeromy-cannon merged commit f4c4320 into main Dec 2, 2024
36 of 37 checks passed
@jeromy-cannon jeromy-cannon deleted the 00511-setup-mirror-node-monitor-pinger-service-1 branch December 2, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup mirror node monitor Pinger service
2 participants