Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed caching of ConfigManager and its flags #713

Merged
merged 28 commits into from
Oct 21, 2024

Conversation

jeromy-cannon
Copy link
Contributor

@jeromy-cannon jeromy-cannon commented Oct 18, 2024

Description

This pull request changes the following:

  • removed caching of ConfigManager and its flags
  • changes to remove lint warnings
  • enhanced update readme workflow so that it will fail correctly if any of the solo calls fail with an error
  • deduplicated .gitignore (lint warnings)
  • updated readme template and readme due to impacted changes
  • added esling: tseslint.configs.recommended
  • added some missing flags for commands that were getting overlooked due to caching
  • fail flag prompt if non-interactive terminal detected
  • made getNodeLogs concurrent
  • set chai config to not truncate error messages
  • removed some TODOs by addressing them

Related Issues

@jeromy-cannon jeromy-cannon self-assigned this Oct 18, 2024
Copy link
Contributor

github-actions bot commented Oct 18, 2024

Unit Test Results - Linux

  1 files   38 suites   9s ⏱️
 97 tests  97 ✅ 0 💤 0 ❌
106 runs  106 ✅ 0 💤 0 ❌

Results for commit efede45.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 18, 2024

Unit Test Results - Windows

  1 files   38 suites   21s ⏱️
 97 tests  97 ✅ 0 💤 0 ❌
106 runs  106 ✅ 0 💤 0 ❌

Results for commit efede45.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon force-pushed the 00676-remove-flag-caching branch from 864f750 to 98e1e9f Compare October 18, 2024 16:26
Copy link

codacy-production bot commented Oct 18, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 3d868e61 86.49%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3d868e6) Report Missing Report Missing Report Missing
Head commit (efede45) 13109 11379 86.80%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#713) 74 64 86.49%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Copy link
Contributor

github-actions bot commented Oct 21, 2024

E2E Test Report

 15 files   96 suites   56m 42s ⏱️
190 tests 190 ✅ 0 💤 0 ❌
193 runs  193 ✅ 0 💤 0 ❌

Results for commit efede45.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 86.48649% with 10 lines in your changes missing coverage. Please review.

Project coverage is 85.77%. Comparing base (af73379) to head (efede45).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/prompts.ts 0.00% 6 Missing ⚠️
src/commands/node.ts 70.00% 3 Missing ⚠️
src/commands/init.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
+ Coverage   85.32%   85.77%   +0.44%     
==========================================
  Files          38       38              
  Lines       13290    13109     -181     
  Branches      862      903      +41     
==========================================
- Hits        11340    11244      -96     
+ Misses       1925     1840      -85     
  Partials       25       25              
Files with missing lines Coverage Δ
src/commands/flags.ts 99.49% <100.00%> (ø)
src/commands/mirror_node.ts 77.52% <100.00%> (ø)
src/commands/relay.ts 81.77% <ø> (-0.10%) ⬇️
src/core/account_manager.ts 84.49% <100.00%> (-0.03%) ⬇️
src/core/config_manager.ts 92.76% <100.00%> (-0.31%) ⬇️
src/core/constants.ts 96.10% <100.00%> (-0.29%) ⬇️
src/core/dependency_managers/dependency_manager.ts 96.82% <100.00%> (ø)
src/core/helpers.ts 91.09% <100.00%> (+0.10%) ⬆️
src/core/k8.ts 90.63% <100.00%> (ø)
src/core/key_manager.ts 91.60% <100.00%> (+7.70%) ⬆️
... and 5 more

... and 1 file with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon marked this pull request as ready for review October 21, 2024 13:14
@jeromy-cannon jeromy-cannon requested review from a team and leninmehedy as code owners October 21, 2024 13:14
@jeromy-cannon jeromy-cannon merged commit 76a61e3 into main Oct 21, 2024
42 of 43 checks passed
@jeromy-cannon jeromy-cannon deleted the 00676-remove-flag-caching branch October 21, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ConfigManager caching capabilities to improve user experience
3 participants