Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename to SoloError #614

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

JeffreyDallas
Copy link
Contributor

Description

This pull request changes the following:

  • rename to SoloError

Related Issues

Signed-off-by: Jeffrey Tang <[email protected]>
Copy link
Contributor

Unit Test Results - Linux

  1 files  ±0   19 suites  ±0   28s ⏱️ +2s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d436f42. ± Comparison against base commit f296aa5.

Copy link
Contributor

Unit Test Results - Windows

  1 files  ±0   19 suites  ±0   51s ⏱️ -1s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d436f42. ± Comparison against base commit f296aa5.

Copy link
Contributor

E2E Test Report

 10 files  ±0   20 suites  ±0   48m 40s ⏱️ -43s
168 tests ±0  168 ✅ ±0  0 💤 ±0  0 ❌ ±0 
171 runs  ±0  171 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d436f42. ± Comparison against base commit f296aa5.

Copy link
Contributor

E2E Test Report

 10 files  ±0   20 suites  ±0   48m 40s ⏱️ -43s
168 tests ±0  168 ✅ ±0  0 💤 ±0  0 ❌ ±0 
171 runs  ±0  171 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d436f42. ± Comparison against base commit f296aa5.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.16% (target: -1.00%) 12.93%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f296aa5) 4080 3305 81.00%
Head commit (d436f42) 4082 (+2) 3313 (+8) 81.16% (+0.16%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#614) 147 19 12.93%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 12.92517% with 128 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (f296aa5) to head (d436f42).
Report is 1 commits behind head on 00592-D-config-yaml.

Files with missing lines Patch % Lines
src/commands/node.mjs 2.85% 34 Missing ⚠️
src/core/k8.mjs 20.00% 24 Missing ⚠️
src/commands/account.mjs 0.00% 11 Missing ⚠️
src/commands/prompts.mjs 0.00% 9 Missing ⚠️
src/core/key_manager.mjs 0.00% 6 Missing ⚠️
src/core/platform_installer.mjs 25.00% 6 Missing ⚠️
src/commands/mirror_node.mjs 0.00% 5 Missing ⚠️
src/core/account_manager.mjs 0.00% 5 Missing ⚠️
src/core/helpers.mjs 0.00% 5 Missing ⚠️
src/core/config_manager.mjs 0.00% 4 Missing ⚠️
... and 9 more
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           00592-D-config-yaml     #614      +/-   ##
=======================================================
+ Coverage                80.87%   81.07%   +0.19%     
=======================================================
  Files                       37       37              
  Lines                     4890     4893       +3     
  Branches                   685      762      +77     
=======================================================
+ Hits                      3955     3967      +12     
+ Misses                     935      926       -9     
Files with missing lines Coverage Δ
src/commands/cluster.mjs 58.01% <100.00%> (ø)
...rc/core/dependency_managers/dependency_manager.mjs 100.00% <100.00%> (ø)
src/core/errors.mjs 100.00% <ø> (ø)
...dependency_managers/keytool_dependency_manager.mjs 69.13% <0.00%> (ø)
src/core/templates.mjs 72.50% <0.00%> (ø)
src/commands/init.mjs 78.94% <0.00%> (ø)
src/core/package_downloader.mjs 92.70% <50.00%> (ø)
src/core/profile_manager.mjs 95.81% <33.33%> (ø)
src/core/zippy.mjs 96.07% <50.00%> (ø)
src/commands/network.mjs 63.15% <0.00%> (-5.79%) ⬇️
... and 12 more

... and 2 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit 134fa55 into 00592-D-config-yaml Sep 19, 2024
30 of 31 checks passed
@jeromy-cannon jeromy-cannon deleted the 00610-D-rename-error branch September 19, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants