Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update readme workflow to use boolean instead of string #594

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: update readme workflow to use boolean instead of string #594

merged 1 commit into from
Sep 17, 2024

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • update readme workflow to use boolean instead of string

Related Issues

@jeromy-cannon jeromy-cannon self-assigned this Sep 17, 2024
@jeromy-cannon jeromy-cannon marked this pull request as ready for review September 17, 2024 20:12
@jeromy-cannon jeromy-cannon requested a review from a team as a code owner September 17, 2024 20:12
@github-actions GitHub Actions
Copy link
Contributor

Unit Test Results - Linux

  1 files   19 suites   24s ⏱️
119 tests 119 ✅ 0 💤 0 ❌
145 runs  145 ✅ 0 💤 0 ❌

Results for commit 4cdf632.

@github-actions GitHub Actions
Copy link
Contributor

Unit Test Results - Windows

  1 files   19 suites   52s ⏱️
119 tests 119 ✅ 0 💤 0 ❌
145 runs  145 ✅ 0 💤 0 ❌

Results for commit 4cdf632.

@github-actions GitHub Actions
Copy link
Contributor

E2E Test Report

 10 files   20 suites   48m 52s ⏱️
168 tests 168 ✅ 0 💤 0 ❌
171 runs  171 ✅ 0 💤 0 ❌

Results for commit 4cdf632.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

E2E Test Report

 10 files   20 suites   48m 52s ⏱️
168 tests 168 ✅ 0 💤 0 ❌
171 runs  171 ✅ 0 💤 0 ❌

Results for commit 4cdf632.

@codacy-production Codacy Production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for e20c5441 ✅ ∅
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e20c544) Report Missing Report Missing Report Missing
Head commit (4cdf632) 4070 3302 81.13%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#594) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (42e1685) to head (4cdf632).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #594   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files          37       37           
  Lines        4880     4880           
  Branches      682      686    +4     
=======================================
  Hits         3955     3955           
  Misses        925      925

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit 1ec09f7 into main Sep 17, 2024
31 checks passed
@jeromy-cannon jeromy-cannon deleted the fix-readme branch September 17, 2024 22:12
This was referenced Sep 18, 2024
Merged
Merged
Merged
Merged
Merged
swirlds-automation added a commit that referenced this pull request Sep 18, 2024
@swirlds-automation
chore(release): 0.30.1 [skip ci]
3b492ba 
## [0.30.1](v0.30.0...v0.30.1) (2024-09-18)

### Bug Fixes

* check if data/upgrade/data/keys exisit ([#587](#587)) ([12bff59](12bff59))
* deploy and tag uses commit-hash from readme ([#601](#601)) ([5d72ffe](5d72ffe))
* more update readme testing ([#599](#599)) ([92d638b](92d638b))
* more update readme testing ([#600](#600)) ([6901f46](6901f46))
* troubleshooting commit-hash ([#602](#602)) ([469f28e](469f28e))
* update readme workflow to use boolean instead of string ([#594](#594)) ([1ec09f7](1ec09f7))
* update readme workflow to use version from semantic-release ([#598](#598)) ([387130f](387130f))
* use the commit hash from the readme publish ([#596](#596)) ([09d6fb4](09d6fb4))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.30.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jeromy-cannon jeromy-cannon mentioned this pull request Sep 18, 2024
Merged
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffreyDallas JeffreyDallas JeffreyDallas approved these changes

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy is a code owner automatically assigned from hashgraph/release-engineering-managers

Assignees

@jeromy-cannon jeromy-cannon

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure that when the Update README.md job runs during Deploy Release Artifact it uses the new version tag
3 participants
@jeromy-cannon @swirlds-automation @JeffreyDallas