Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configuration for Monitor Pinger service #512

Closed
wants to merge 5 commits into from

Conversation

Ivo-Yankov
Copy link
Contributor

Description

Related Issues

@Ivo-Yankov Ivo-Yankov self-assigned this Aug 23, 2024
@Ivo-Yankov Ivo-Yankov added the Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Aug 23, 2024
@Ivo-Yankov Ivo-Yankov changed the title Add configuration for Monitor Pinger service feat: add configuration for Monitor Pinger service Aug 23, 2024
Signed-off-by: Ivo Yankov <[email protected]>
Copy link
Contributor

github-actions bot commented Aug 23, 2024

E2E Mirror Node Tests Coverage Report

 1 files  ±0  1 suites  ±0   1m 38s ⏱️ - 2m 21s
12 tests ±0  6 ✅  - 6  5 💤 +5  1 ❌ +1 
13 runs  ±0  6 ✅  - 7  6 💤 +6  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 0b4b793. ± Comparison against base commit fa3a316.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 23, 2024

E2E Relay Tests Coverage Report

1 files  ±0  1 suites  ±0   2m 41s ⏱️ -1s
5 tests ±0  5 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  6 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0b4b793. ± Comparison against base commit fa3a316.

♻️ This comment has been updated with latest results.

@JeffreyDallas
Copy link
Contributor

Maybe add a flag so user has an option to turn on or off pinger service,
my experience is there are many background transactions from pingers, sometimes had to check log when debugging other issues.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Unit Test Results - Linux

  1 files  ±0   19 suites  ±0   46s ⏱️ ±0s
126 tests ±0  126 ✅ ±0  0 💤 ±0  0 ❌ ±0 
152 runs  ±0  152 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0b4b793. ± Comparison against base commit fa3a316.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Unit Test Results - Windows

  1 files  ±0   19 suites  ±0   1m 34s ⏱️ +3s
126 tests ±0  126 ✅ ±0  0 💤 ±0  0 ❌ ±0 
152 runs  ±0  152 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0b4b793. ± Comparison against base commit fa3a316.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

E2E Node PEM Stop Tests Coverage Report

12 tests  ±0   12 ✅ ±0   2m 37s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 0b4b793. ± Comparison against base commit fa3a316.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

E2E Node PFX Kill Tests Coverage Report

12 tests  ±0   12 ✅ ±0   2m 52s ⏱️ +2s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 0b4b793. ± Comparison against base commit fa3a316.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

E2E Tests Coverage Report

57 tests  ±0   57 ✅ ±0   3m 16s ⏱️ -51s
 9 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 0b4b793. ± Comparison against base commit fa3a316.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

E2E Node Local Build Tests Coverage Report

8 tests  ±0   8 ✅ ±0   2m 44s ⏱️ -2s
2 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 0b4b793. ± Comparison against base commit fa3a316.

Copy link
Contributor

github-actions bot commented Sep 2, 2024

E2E Node Add Tests Coverage Report

20 tests  ±0   16 ✅ ±0   11m 13s ⏱️ +11s
 2 suites ±0    3 💤 ±0 
 1 files   ±0    1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0b4b793. ± Comparison against base commit fa3a316.

@jeromy-cannon
Copy link
Contributor

pick back up later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Enhancement Enhancing an existing feature driven by business requirements. Typically backwards compatible.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Setup mirror node monitor Pinger service
3 participants