New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce number of account used e2e init account test #477

Merged

jeromy-cannon merged 5 commits into main from 00476-D-reduce-init-account

Aug 12, 2024

Contributor

JeffreyDallas commented Aug 9, 2024

Description

This pull request changes the following:

Reduce number of account used e2e init account test

Related Issues

Closes Reduce number of account used in init account testing #476

JeffreyDallas added 2 commits

August 9, 2024 13:46


          fix: use smaller set for account init test

ea3a6ea

Signed-off-by: Jeffrey Tang <[email protected]>


          save

495bbfc

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas requested review from leninmehedy and a team as code owners

August 9, 2024 22:17

JeffreyDallas requested a review from jeromy-cannon

August 9, 2024 22:17

Contributor

github-actions bot commented Aug 9, 2024 •

edited

Loading

Unit Test Results - Linux

1 files ±0 19 suites ±0 1m 31s ⏱️ -32s
124 tests ±0 124 ✅ ±0 0 💤 ±0 0 ❌ ±0
150 runs ±0 150 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 586998f. ± Comparison against base commit 0ac484d.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Aug 9, 2024 •

edited

Loading

Unit Test Results - Windows

1 files ±0 19 suites ±0 1m 40s ⏱️ +13s
124 tests ±0 124 ✅ ±0 0 💤 ±0 0 ❌ ±0
150 runs ±0 150 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 586998f. ± Comparison against base commit 0ac484d.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Aug 9, 2024 •

edited

Loading

E2E Node PFX Kill Add Tests Coverage Report

1 files 1 suites 9m 30s ⏱️
18 tests 18 ✅ 0 💤 0 ❌
20 runs 20 ✅ 0 💤 0 ❌

Results for commit 586998f.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Aug 9, 2024 •

edited

Loading

E2E Tests Coverage Report

55 tests 55 ✅ 4m 59s ⏱️
9 suites 0 💤
1 files 0 ❌

Results for commit 586998f.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Aug 9, 2024 •

edited

Loading

E2E Node PEM Stop Add Tests Coverage Report

1 files 1 suites 7m 18s ⏱️
18 tests 18 ✅ 0 💤 0 ❌
20 runs 20 ✅ 0 💤 0 ❌

Results for commit 586998f.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Aug 9, 2024 •

edited

Loading

E2E Node Local Build Tests Coverage Report

8 tests 8 ✅ 5m 6s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit 586998f.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Aug 9, 2024 •

edited

Loading

E2E Mirror Node Tests Coverage Report

11 tests 11 ✅ 3m 37s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 586998f.

♻️ This comment has been updated with latest results.

Contributor

github-actions bot commented Aug 9, 2024 •

edited

Loading

E2E Relay Tests Coverage Report

1 files 1 suites 2m 37s ⏱️
5 tests 5 ✅ 0 💤 0 ❌
6 runs 6 ✅ 0 💤 0 ❌

Results for commit 586998f.

♻️ This comment has been updated with latest results.

JeffreyDallas added 2 commits

August 9, 2024 22:52


          save

13f6c83

Signed-off-by: Jeffrey Tang <[email protected]>


          save

ae0c073

Signed-off-by: Jeffrey Tang <[email protected]>

codacy-production bot commented Aug 10, 2024 •

edited

Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `0ac484d`¹	✅ 100.00%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`0ac484d`)	Report Missing	Report Missing	Report Missing
Head commit (`586998f`)	3501	2842	81.18%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#477)	1	1	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩


          Merge commit '0ac484ddfd7d2990b251633fe6f2f216bb0b537b' into 00476-D-…

586998f

…reduce-init-account

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	src/core/constants.mjs

codecov bot commented Aug 10, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.87%. Comparing base (67f47c1) to head (586998f).
Report is 49 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
+ Coverage   81.44%   81.87%   +0.43%     
==========================================
  Files          35       35              
  Lines        4095     4182      +87     
  Branches      719      725       +6     
==========================================
+ Hits         3335     3424      +89     
+ Misses        760      758       -2

Files	Coverage Δ
src/core/constants.mjs	`94.04% <100.00%> (+0.14%)`	⬆️

... and 3 files with indirect coverage changes

jeromy-cannon approved these changes

View reviewed changes

jeromy-cannon merged commit 51d7ade into main

33 checks passed

jeromy-cannon deleted the 00476-D-reduce-init-account branch

August 12, 2024 10:29

swirlds-automation added a commit that referenced this pull request


          chore(release): 0.28.0 [skip ci]

d5acbe3

## [0.28.0](v0.27.0...v0.28.0) (2024-08-26)

### Features

* add freeze account ([#436](#436)) ([8fe5a41](8fe5a41))
* enhance node add to work with staking and dynamic address book ([#469](#469)) ([b452599](b452599))
* use k8s configMaps to mount files during solo network deploy  ([#345](#345)) ([af27f16](af27f16))

### Bug Fixes

* hugo jsdoc failure ([#498](#498)) ([ff07413](ff07413))
* reduce number of account used e2e init account test ([#477](#477)) ([51d7ade](51d7ade))
* Resolve various problems to enable tests from local-node and smart-contracts to run agains solo network ([#402](#402)) ([c99d881](c99d881))
* use path.join instead of forward slashes to support Windows ([#491](#491)) ([82a5053](82a5053))

Contributor

swirlds-automation commented Aug 26, 2024

🎉 This PR is included in version 0.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels