Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add steps for running unit test on windows platform #225

Merged
merged 15 commits into from
Apr 11, 2024

Conversation

JeffreyDallas
Copy link
Contributor

Description

This pull request changes the following:

  • Adding new steps to be able to run unit test & report coverage on windows platform

Related Issues

@JeffreyDallas JeffreyDallas requested review from a team and leninmehedy as code owners April 10, 2024 14:22
@JeffreyDallas JeffreyDallas marked this pull request as draft April 10, 2024 14:22
@wiz-inc-8f76296f7c
Copy link

wiz-inc-8f76296f7c bot commented Apr 10, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 4M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 4M 0L 0I
Secrets 0🔑

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Unit Test Results - Windows

  1 files   17 suites   1m 29s ⏱️
114 tests 114 ✅ 0 💤 0 ❌
139 runs  139 ✅ 0 💤 0 ❌

Results for commit 8f635f7.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Unit Test Results - Linux

  1 files   17 suites   1m 18s ⏱️
114 tests 114 ✅ 0 💤 0 ❌
139 runs  139 ✅ 0 💤 0 ❌

Results for commit 8f635f7.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 10, 2024

E2E Test Results

 1 files  ±0  10 suites  ±0   11m 57s ⏱️ - 1m 3s
84 tests ±0  84 ✅ ±0  0 💤 ±0  0 ❌ ±0 
86 runs  ±0  86 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8f635f7. ± Comparison against base commit d1017d8.

♻️ This comment has been updated with latest results.

JeffreyDallas and others added 10 commits April 10, 2024 16:24
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas JeffreyDallas force-pushed the 00129-solo-windows-runner2 branch from a6199ac to 102a37f Compare April 10, 2024 21:24
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.04% (target: -1.00%) 66.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d1017d8) 2985 2333 78.16%
Head commit (8f635f7) 2993 (+8) 2338 (+5) 78.12% (-0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#225) 6 4 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 77.86%. Comparing base (d1017d8) to head (8f635f7).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   77.91%   77.86%   -0.05%     
==========================================
  Files          33       33              
  Lines        3554     3560       +6     
  Branches      575      579       +4     
==========================================
+ Hits         2769     2772       +3     
- Misses        785      788       +3     
Files Coverage Δ
...re/dependency_managers/helm_dependency_manager.mjs 90.32% <75.00%> (-1.21%) ⬇️
...dependency_managers/keytool_dependency_manager.mjs 87.50% <75.00%> (-0.82%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

@JeffreyDallas JeffreyDallas marked this pull request as ready for review April 11, 2024 01:39
@JeffreyDallas JeffreyDallas merged commit 07f5fe4 into main Apr 11, 2024
23 of 25 checks passed
@JeffreyDallas JeffreyDallas deleted the 00129-solo-windows-runner2 branch April 11, 2024 19:40
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test that solo can be run on windows
3 participants