Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if data/upgrade/data/keys exisit #587

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

JeffreyDallas
Copy link
Contributor

Description

This pull request changes the following:

  • check if data/upgrade/data/keys exisit

Related Issues

@JeffreyDallas JeffreyDallas requested review from leninmehedy and a team as code owners September 17, 2024 16:31
Copy link
Contributor

Unit Test Results - Linux

  1 files  ±0   19 suites  ±0   26s ⏱️ -1s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6805cda. ± Comparison against base commit ae1c949.

Copy link
Contributor

Unit Test Results - Windows

  1 files  ±0   19 suites  ±0   57s ⏱️ +4s
119 tests ±0  119 ✅ ±0  0 💤 ±0  0 ❌ ±0 
145 runs  ±0  145 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 6805cda. ± Comparison against base commit ae1c949.

Copy link
Contributor

github-actions bot commented Sep 17, 2024

E2E Test Report

 10 files   20 suites   49m 21s ⏱️
168 tests 168 ✅ 0 💤 0 ❌
171 runs  171 ✅ 0 💤 0 ❌

Results for commit 6805cda.

♻️ This comment has been updated with latest results.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for ae1c9491 83.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ae1c949) Report Missing Report Missing Report Missing
Head commit (6805cda) 4073 3305 81.14%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#587) 6 5 83.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (b8f65a6) to head (6805cda).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/node.mjs 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   81.05%   81.05%           
=======================================
  Files          37       37           
  Lines        4882     4883    +1     
  Branches      761      760    -1     
=======================================
+ Hits         3957     3958    +1     
  Misses        925      925           
Files with missing lines Coverage Δ
src/commands/node.mjs 80.44% <83.33%> (+0.04%) ⬆️

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit 12bff59 into main Sep 18, 2024
30 checks passed
@jeromy-cannon jeromy-cannon deleted the 0541-D-fix-upgrade-keydir branch September 18, 2024 09:42
swirlds-automation added a commit that referenced this pull request Sep 18, 2024
## [0.30.1](v0.30.0...v0.30.1) (2024-09-18)

### Bug Fixes

* check if data/upgrade/data/keys exisit ([#587](#587)) ([12bff59](12bff59))
* deploy and tag uses commit-hash from readme ([#601](#601)) ([5d72ffe](5d72ffe))
* more update readme testing ([#599](#599)) ([92d638b](92d638b))
* more update readme testing ([#600](#600)) ([6901f46](6901f46))
* troubleshooting commit-hash ([#602](#602)) ([469f28e](469f28e))
* update readme workflow to use boolean instead of string ([#594](#594)) ([1ec09f7](1ec09f7))
* update readme workflow to use version from semantic-release ([#598](#598)) ([387130f](387130f))
* use the commit hash from the readme publish ([#596](#596)) ([09d6fb4](09d6fb4))
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.30.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix needed to avoid Node Add/Update/Delete breaking in future version
3 participants