feat: remove pfx support #537

JeffreyDallas · 2024-09-03T18:26:27Z

Description

This pull request changes the following:

Remove all pfx related code and files

Related Issues

Closes Remove pfx file type support in Solo #504

Signed-off-by: Jeffrey Tang <[email protected]>

github-actions · 2024-09-03T18:28:30Z

Unit Test Results - Linux

1 files 19 suites 25s ⏱️
122 tests 122 ✅ 0 💤 0 ❌
148 runs 148 ✅ 0 💤 0 ❌

Results for commit 33ae3e2.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-03T18:29:30Z

Unit Test Results - Windows

1 files 19 suites 51s ⏱️
122 tests 122 ✅ 0 💤 0 ❌
148 runs 148 ✅ 0 💤 0 ❌

Results for commit 33ae3e2.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-03T18:31:36Z

E2E Relay Tests Coverage Report

1 files 1 suites 2m 40s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs 7 ✅ 0 💤 0 ❌

Results for commit 33ae3e2.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-03T18:31:54Z

E2E Node PEM Stop Tests Coverage Report

13 tests 13 ✅ 2m 27s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 33ae3e2.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-03T18:32:00Z

E2E Node Update Tests Coverage Report

12 tests 12 ✅ 5m 31s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 33ae3e2.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-03T18:32:32Z

E2E Node Local Build Tests Coverage Report

10 tests 10 ✅ 2m 20s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit 33ae3e2.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-03T18:32:55Z

E2E Tests Coverage Report

58 tests 58 ✅ 3m 57s ⏱️
9 suites 0 💤
1 files 0 ❌

Results for commit 33ae3e2.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-03T18:35:11Z

E2E Node Delete Tests Coverage Report

10 tests 10 ✅ 6m 15s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 33ae3e2.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-03T18:37:45Z

E2E Mirror Node Tests Coverage Report

1 files 1 suites 3m 50s ⏱️
13 tests 13 ✅ 0 💤 0 ❌
14 runs 14 ✅ 0 💤 0 ❌

Results for commit 33ae3e2.

♻️ This comment has been updated with latest results.

github-actions · 2024-09-03T18:43:58Z

E2E Node Add Tests Coverage Report

22 tests 22 ✅ 14m 31s ⏱️
2 suites 0 💤
1 files 0 ❌

Results for commit 33ae3e2.

♻️ This comment has been updated with latest results.

codacy-production · 2024-09-03T18:45:19Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `cf23325`¹	✅ 89.74%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`cf23325`)	Report Missing	Report Missing	Report Missing
Head commit (`33ae3e2`)	4035	3171	78.59%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#537)	39	35	89.74%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2024-09-03T18:45:55Z

Codecov Report

Attention: Patch coverage is 95.65217% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.17%. Comparing base (c81c76a) to head (33ae3e2).
Report is 57 commits behind head on main.

Files with missing lines	Patch %	Lines
src/commands/prompts.mjs	0.00%	1 Missing ⚠️
src/core/key_manager.mjs	94.44%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
+ Coverage   81.66%   83.17%   +1.51%     
==========================================
  Files          35       36       +1     
  Lines        4429     4815     +386     
  Branches      671      743      +72     
==========================================
+ Hits         3617     4005     +388     
+ Misses        812      810       -2

Files with missing lines	Coverage Δ
src/commands/flags.mjs	`95.94% <ø> (+0.42%)`	⬆️
src/commands/init.mjs	`78.94% <ø> (ø)`
src/commands/network.mjs	`62.18% <100.00%> (+6.63%)`	⬆️
src/commands/node.mjs	`85.07% <100.00%> (+6.32%)`	⬆️
src/core/constants.mjs	`94.25% <ø> (-0.20%)`	⬇️
src/core/helpers.mjs	`89.34% <ø> (-2.72%)`	⬇️
src/core/platform_installer.mjs	`88.80% <100.00%> (+2.35%)`	⬆️
src/core/templates.mjs	`72.50% <ø> (-4.43%)`	⬇️
test/e2e/e2e_node_util.js	`87.91% <100.00%> (-0.14%)`	⬇️
test/test_add.mjs	`100.00% <100.00%> (ø)`
... and 3 more

... and 3 files with indirect coverage changes

src/commands/flags.mjs

src/commands/node.mjs

test/e2e/commands/node_pfx_kill.test.mjs

Signed-off-by: Jeffrey Tang <[email protected]>

Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/commands/node.mjs # src/core/helpers.mjs # src/core/key_manager.mjs # src/core/platform_installer.mjs # src/core/templates.mjs # test/e2e/commands/node-update.test.mjs # test/e2e/core/platform_installer_e2e.test.mjs

github-actions · 2024-09-04T15:15:58Z

E2E Node PEM Kill Tests Coverage Report

13 tests 13 ✅ 2m 48s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit 33ae3e2.

♻️ This comment has been updated with latest results.

Signed-off-by: Jeffrey Tang <[email protected]>

jeromy-cannon · 2024-09-04T20:18:22Z

It is strange. we already renamed one of step from "Node PFX Kill" to "Node PEM Kill", but "Node PFX Kill" still showed up as one of checks waiting to be reported

@JeffreyDallas , we have to merge it to main, then update the settings in the rules for the new test name.

src/core/templates.mjs

test/e2e/commands/node_pem_kill.test.mjs

test/e2e/commands/node_pem_stop.test.mjs

.github/workflows/flow-update-readme.yaml

.github/workflows/script/relay_smoke_test.sh

README.md.template

jeromy-cannon

Looks like test/scripts/gen-openssl-keys.sh references pfx, also

@JeffreyDallas , did you see this comment?

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Signed-off-by: Jeffrey Tang <[email protected]>

…remove-pfx Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # .github/workflows/flow-update-readme.yaml # .github/workflows/script/relay_smoke_test.sh # README.md.template # test/e2e/commands/account.test.mjs # test/e2e/commands/cluster.test.mjs # test/e2e/commands/network.test.mjs # test/e2e/commands/node-local-hedera.test.mjs # test/e2e/commands/node-local-ptt.test.mjs # test/e2e/e2e_node_util.js # test/unit/core/key_manager.test.mjs # test/unit/core/keytool.test.mjs

…remove-pfx Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/core/key_manager.mjs # src/core/platform_installer.mjs

Signed-off-by: Jeffrey Tang <[email protected]>

## [0.30.0](v0.29.0...v0.30.0) (2024-09-17) ### Features * add node add-prepare and node add-execute commands ([#533](#533)) ([a184775](a184775)) * add support for attach jvm debugger ([#549](#549)) ([35a0075](35a0075)) * add the autogen tool to easily add e2e tests and run it for the first time & fix copyFrom ([#566](#566)) ([e6c79eb](e6c79eb)) * **network node livecheck:** implement a functionality to determine network node activeness with prometheus metrics ([#567](#567)) ([6120775](6120775)) * remove pfx support ([#537](#537)) ([aff5f63](aff5f63)) ### Bug Fixes * aligned test names to naming pattern ([#554](#554)) ([365f724](365f724)) * download application.properties file if it was generated by hedera app during handling address book change ([#571](#571)) ([35c73d8](35c73d8)) * **functionality:** removed the 'z' from the 'tar' command on the K8.copyFrom ([#561](#561)) ([796474b](796474b)) * have update readme run after version calculation in deploy and release ([#586](#586)) ([42e1685](42e1685)) * jsdoc errors due to unrecognized format ([#557](#557)) ([da7113b](da7113b)) * remove of using agreement key in hedera repo test ([#563](#563)) ([05c5517](05c5517)) * separate repeated steps as individual functions ([#562](#562)) ([dcbbe5e](dcbbe5e))

swirlds-automation · 2024-09-17T19:29:47Z

🎉 This PR is included in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

feat: remove pfx support

e6bba36

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas requested review from a team and leninmehedy as code owners September 3, 2024 18:26

Merge branch 'main' into 00504-D-remove-pfx

efe5bbd

JeffreyDallas requested a review from jeromy-cannon September 3, 2024 21:23

jeromy-cannon assigned JeffreyDallas Sep 4, 2024

jeromy-cannon reviewed Sep 4, 2024

View reviewed changes

src/commands/flags.mjs Show resolved Hide resolved

jeromy-cannon reviewed Sep 4, 2024

View reviewed changes

src/commands/node.mjs Outdated Show resolved Hide resolved

jeromy-cannon reviewed Sep 4, 2024

View reviewed changes

test/e2e/commands/node_pfx_kill.test.mjs Show resolved Hide resolved

JeffreyDallas added 4 commits September 4, 2024 09:24

remove switch/case

8e39be1

rename node_pfx_kill to node_pfm_kill

d5534be

more pfx removal

c34f8b6

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas added 3 commits September 4, 2024 10:16

revert

399b534

Signed-off-by: Jeffrey Tang <[email protected]>

spotless check

51620c3

Signed-off-by: Jeffrey Tang <[email protected]>

save

f3c1163

Signed-off-by: Jeffrey Tang <[email protected]>

jeromy-cannon reviewed Sep 4, 2024

View reviewed changes

src/core/templates.mjs Outdated Show resolved Hide resolved

jeromy-cannon reviewed Sep 4, 2024

View reviewed changes

test/e2e/commands/node_pem_kill.test.mjs Outdated Show resolved Hide resolved

jeromy-cannon reviewed Sep 4, 2024

View reviewed changes

test/e2e/commands/node_pem_stop.test.mjs Outdated Show resolved Hide resolved

jeromy-cannon reviewed Sep 4, 2024

View reviewed changes

.github/workflows/flow-update-readme.yaml Outdated Show resolved Hide resolved

jeromy-cannon reviewed Sep 4, 2024

View reviewed changes

.github/workflows/flow-update-readme.yaml Outdated Show resolved Hide resolved

jeromy-cannon reviewed Sep 4, 2024

View reviewed changes

.github/workflows/script/relay_smoke_test.sh Outdated Show resolved Hide resolved

jeromy-cannon reviewed Sep 4, 2024

View reviewed changes

README.md.template Outdated Show resolved Hide resolved

jeromy-cannon reviewed Sep 4, 2024

View reviewed changes

README.md.template Outdated Show resolved Hide resolved

jeromy-cannon requested changes Sep 4, 2024

View reviewed changes

JeffreyDallas and others added 9 commits September 5, 2024 09:23

Update README.md.template

0aa4ad8

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Update README.md.template

2fc5b94

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Update .github/workflows/script/relay_smoke_test.sh

79f3728

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Update .github/workflows/flow-update-readme.yaml

e393c68

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Update .github/workflows/flow-update-readme.yaml

097dc57

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Update test/e2e/commands/node_pem_stop.test.mjs

5d097d1

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

Update test/e2e/commands/node_pem_kill.test.mjs

8641ce0

Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: JeffreyDallas <[email protected]>

revert

085f4c2

Signed-off-by: Jeffrey Tang <[email protected]>

JeffreyDallas requested a review from jeromy-cannon September 6, 2024 14:03

JeffreyDallas and others added 4 commits September 6, 2024 13:43

Merge commit 'd8e5032e1c97a147fac3003f7c5d75b3cd2b5aa1' into 00504-D-…

d0b779c

…remove-pfx Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # src/core/key_manager.mjs # src/core/platform_installer.mjs

save

11e495f

Signed-off-by: Jeffrey Tang <[email protected]>

save

a178103

Signed-off-by: Jeffrey Tang <[email protected]>

Merge branch 'main' into 00504-D-remove-pfx

33ae3e2

jeromy-cannon approved these changes Sep 9, 2024

View reviewed changes

jeromy-cannon merged commit aff5f63 into main Sep 9, 2024
39 checks passed

jeromy-cannon deleted the 00504-D-remove-pfx branch September 9, 2024 14:42

swirlds-automation added the released label Sep 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: remove pfx support #537

feat: remove pfx support #537

JeffreyDallas commented Sep 3, 2024

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

codacy-production bot commented Sep 3, 2024 •

edited

Loading

codecov bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

jeromy-cannon commented Sep 4, 2024

jeromy-cannon left a comment •

edited

Loading

swirlds-automation commented Sep 17, 2024

feat: remove pfx support #537

feat: remove pfx support #537

Conversation

JeffreyDallas commented Sep 3, 2024

Description

Related Issues

github-actions bot commented Sep 3, 2024 • edited Loading

Unit Test Results - Linux

github-actions bot commented Sep 3, 2024 • edited Loading

Unit Test Results - Windows

github-actions bot commented Sep 3, 2024 • edited Loading

E2E Relay Tests Coverage Report

github-actions bot commented Sep 3, 2024 • edited Loading

E2E Node PEM Stop Tests Coverage Report

github-actions bot commented Sep 3, 2024 • edited Loading

E2E Node Update Tests Coverage Report

github-actions bot commented Sep 3, 2024 • edited Loading

E2E Node Local Build Tests Coverage Report

github-actions bot commented Sep 3, 2024 • edited Loading

E2E Tests Coverage Report

github-actions bot commented Sep 3, 2024 • edited Loading

E2E Node Delete Tests Coverage Report

github-actions bot commented Sep 3, 2024 • edited Loading

E2E Mirror Node Tests Coverage Report

github-actions bot commented Sep 3, 2024 • edited Loading

E2E Node Add Tests Coverage Report

codacy-production bot commented Sep 3, 2024 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

codecov bot commented Sep 3, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 4, 2024 • edited Loading

E2E Node PEM Kill Tests Coverage Report

jeromy-cannon commented Sep 4, 2024

jeromy-cannon left a comment • edited Loading

Choose a reason for hiding this comment

swirlds-automation commented Sep 17, 2024

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 3, 2024 •

edited

Loading

codacy-production bot commented Sep 3, 2024 •

edited

Loading

codecov bot commented Sep 3, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

jeromy-cannon left a comment •

edited

Loading