Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pfx file type support in Solo #504

Closed
Tracked by #47
jeromy-cannon opened this issue Aug 21, 2024 · 1 comment · Fixed by #537
Closed
Tracked by #47

Remove pfx file type support in Solo #504

jeromy-cannon opened this issue Aug 21, 2024 · 1 comment · Fixed by #537
Assignees
Labels
Improvement Code changes driven by non business requirements P3 Low priority issue. Will not impact the release schedule if not complete. released Tech Debt Changes that are needed to keep up with tech debt

Comments

@jeromy-cannon
Copy link
Contributor

jeromy-cannon commented Aug 21, 2024

not needed since we are going to only support 0.51 and higher. I followed up with Edward, it looks like 0.51 and higher we no longer need to support PFX in Solo, platform still supports PFX, but PEM is preferred.

a list of files that need to be changed, their might be more, this is just searching for pfx:

  • platform_installer.mjs
  • flags.mjs, since there will be only one option PEM, then we can remove this flag, which will trigger a need to cascade update other files
  • node.mjs
  • prompts.mjs
  • constants.mjs
  • helpers.mjs
  • key_manager.mjs
  • templates.mjs
  • node-local-hedera.test.mjs
  • node-local-ptt.test.mjs
  • node_pfx_kill.test.mjs
  • test_util.js
  • key_manager.test.mjs
  • keytool.test.mjs
@jeromy-cannon jeromy-cannon changed the title Remove pfx file type support in Remove pfx file type support in Solo Aug 21, 2024
@jeromy-cannon jeromy-cannon added the P3 Low priority issue. Will not impact the release schedule if not complete. label Aug 21, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Solo Aug 21, 2024
@jeromy-cannon jeromy-cannon moved this from 🆕 New to 🔖 Ready in Solo Aug 22, 2024
@jeromy-cannon jeromy-cannon added Improvement Code changes driven by non business requirements Tech Debt Changes that are needed to keep up with tech debt labels Aug 22, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Solo Sep 9, 2024
@swirlds-automation
Copy link
Contributor

🎉 This issue has been resolved in version 0.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements P3 Low priority issue. Will not impact the release schedule if not complete. released Tech Debt Changes that are needed to keep up with tech debt
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants