fix: Resolve various problems to enable tests from local-node and smart-contracts to run agains solo network #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
leninmehedy
reviewed
Jul 1, 2024
leninmehedy
reviewed
Jul 1, 2024
leninmehedy
reviewed
Jul 1, 2024
…-solo-is-covering-all-local-node-flows
…-solo-is-covering-all-local-node-flows
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
…ering-all-local-node-flows
…ering-all-local-node-flows
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
leninmehedy
reviewed
Aug 6, 2024
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
…ing-make-sure-solo-is-covering-all-local-node-flows Signed-off-by: Jeffrey Tang <[email protected]>
JeffreyDallas
previously approved these changes
Aug 12, 2024
Signed-off-by: Jeffrey Tang <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 81.89% 81.99% +0.09%
==========================================
Files 35 35
Lines 4182 4216 +34
Branches 644 648 +4
==========================================
+ Hits 3425 3457 +32
- Misses 757 759 +2
... and 1 file with indirect coverage changes |
JeffreyDallas
approved these changes
Aug 12, 2024
JeffreyDallas
deleted the
353-testing-make-sure-solo-is-covering-all-local-node-flows
branch
swirlds-automation
added a commit
that referenced
this pull request
Aug 26, 2024
## [0.28.0](v0.27.0...v0.28.0) (2024-08-26) ### Features * add freeze account ([#436](#436)) ([8fe5a41](8fe5a41)) * enhance node add to work with staking and dynamic address book ([#469](#469)) ([b452599](b452599)) * use k8s configMaps to mount files during solo network deploy ([#345](#345)) ([af27f16](af27f16)) ### Bug Fixes * hugo jsdoc failure ([#498](#498)) ([ff07413](ff07413)) * reduce number of account used e2e init account test ([#477](#477)) ([51d7ade](51d7ade)) * Resolve various problems to enable tests from local-node and smart-contracts to run agains solo network ([#402](#402)) ([c99d881](c99d881)) * use path.join instead of forward slashes to support Windows ([#491](#491)) ([82a5053](82a5053))
|
🎉 This PR is included in version 0.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/api/v1/contract/callresulted inerror: 500. Adds a new step at the end ofsolo mirror-node deploythat executes a script that inserts 2 rows into thepublic.file_datatable - the data forfileDataand forexchangeRates.sidecarsto be processed by the importer. Because they were not enabled all contract state data was not imported into the Mirror node and all requests to/api/v1/contract/callreturned0x.bootstrap.propertiestoapplication.propertiesto override the default configuration for post-modularization versions of Services.Related Issues