Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Update per Q3 audit findings #998

Closed
wants to merge 2 commits into from
Closed

ci: Update per Q3 audit findings #998

wants to merge 2 commits into from

Conversation

mishomihov00
Copy link
Contributor

Description:

Update per Q3 audit findings

Related issue(s):

Related to #872

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mishomihov00 mishomihov00 self-assigned this Oct 30, 2024
@mishomihov00 mishomihov00 requested review from a team as code owners October 30, 2024 12:57
@mishomihov00 mishomihov00 linked an issue Oct 30, 2024 that may be closed by this pull request
ci: [2024-Q3] CI/CD Audit Story #872
Closed
57 tasks
@mishomihov00 mishomihov00 requested a review from acuarica October 30, 2024 12:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 30, 2024 •
edited
Loading

Test Results

 16 files  ±0   83 suites  ±0   11m 50s ⏱️ -7s
294 tests ±0  288 ✅ ±0  6 💤 ±0  0 ❌ ±0 
303 runs  ±0  296 ✅ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit f220f9c. ± Comparison against base commit 756469f.

♻️ This comment has been updated with latest results.

@mishomihov00 mishomihov00 added the github_actions Pull requests that update GitHub Actions code label Oct 30, 2024
@mishomihov00 mishomihov00 added this to the 0.11.0 milestone Oct 30, 2024
@andrewb1269hg andrewb1269hg mentioned this pull request Oct 30, 2024
Closed
57 tasks
quiet-node
quiet-node previously approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 1 qq

.github/workflows/foundry_test.yml Show resolved Hide resolved
quiet-node
quiet-node previously approved these changes Oct 31, 2024
View reviewed changes
.github/workflows/foundry_test.yml Outdated Show resolved Hide resolved
@mishomihov00 mishomihov00 force-pushed the 872-ci-2024-q3-cicd-audit-story branch from 489ad0b to f220f9c Compare November 1, 2024 07:21
@mishomihov00 mishomihov00 force-pushed the 872-ci-2024-q3-cicd-audit-story branch from f220f9c to 5e4fd3d Compare November 1, 2024 08:38
@mishomihov00
ci: Disable npm caching
da68b9d 
Signed-off-by: Mihail Mihov <[email protected]>
@mishomihov00 mishomihov00 force-pushed the 872-ci-2024-q3-cicd-audit-story branch from 5e4fd3d to da68b9d Compare November 1, 2024 08:40
@mishomihov00 mishomihov00 mentioned this pull request Nov 1, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quiet-node quiet-node quiet-node left review comments

@dalvizu dalvizu Awaiting requested review from dalvizu dalvizu is a code owner automatically assigned from hashgraph/devops-ci

@nathanklick nathanklick Awaiting requested review from nathanklick nathanklick is a code owner automatically assigned from hashgraph/release-engineering-managers

@acuarica acuarica Awaiting requested review from acuarica acuarica is a code owner automatically assigned from hashgraph/hedera-smart-contracts

Assignees

@mishomihov00 mishomihov00

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

ci: [2024-Q3] CI/CD Audit Story
2 participants
@mishomihov00 @quiet-node