Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added example to showcase OZ ERC1967Upgrade (#613) #615

Merged
merged 5 commits into from
Dec 13, 2023
Merged

feat: added example to showcase OZ ERC1967Upgrade (#613) #615

merged 5 commits into from
Dec 13, 2023

Conversation

quiet-node
Copy link
Member

Description:

  • added VoteV1, VoteV2, ProxyVote solidity contracts
  • added tests to cover the contracts

Related issue(s):

Fixes #613

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added enhancement New feature or request EVM evm related Tooling tooling labels Dec 6, 2023
@quiet-node quiet-node self-assigned this Dec 6, 2023
@quiet-node quiet-node linked an issue Dec 6, 2023 that may be closed by this pull request
Add OZ erc1967upgrade example #613
Closed
@quiet-node quiet-node force-pushed the 613-add-oz-erc1967upgrade-example branch from 42333bb to a88e4c5 Compare December 6, 2023 05:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

Test Results

240 tests  +7   234 ✔️ +8   8m 21s ⏱️ +14s
  71 suites +2       6 💤 ±0 
  14 files   ±0       0 ❌  - 1 

Results for commit 827d7a6. ± Comparison against base commit 5804b9d.

♻️ This comment has been updated with latest results.

Nana-EC
Nana-EC requested changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
Some test suggestions

contracts/solidity/oz/ERC1967Upgrade/VoteProxy.sol Outdated Show resolved Hide resolved
contracts/solidity/oz/ERC1967Upgrade/VoteV1.sol Show resolved Hide resolved
test/solidity/oz/ERC1967Upgrade/Vote.js Outdated Show resolved Hide resolved
@quiet-node quiet-node force-pushed the 613-add-oz-erc1967upgrade-example branch from 6438b60 to 827d7a6 Compare December 12, 2023 21:53
@quiet-node quiet-node requested a review from Nana-EC December 12, 2023 21:54
@quiet-node quiet-node merged commit 90b6707 into main Dec 13, 2023
23 checks passed
@quiet-node quiet-node deleted the 613-add-oz-erc1967upgrade-example branch December 13, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nana-EC Nana-EC Nana-EC approved these changes

@AlfredoG87 AlfredoG87 Awaiting requested review from AlfredoG87

@AleksandrinaAleksieva AleksandrinaAleksieva Awaiting requested review from AleksandrinaAleksieva

@ebadiere ebadiere Awaiting requested review from ebadiere

@georgi-l95 georgi-l95 Awaiting requested review from georgi-l95 georgi-l95 is a code owner

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov Ivo-Yankov is a code owner

@natanasow natanasow Awaiting requested review from natanasow natanasow is a code owner

@yiliev0 yiliev0 Awaiting requested review from yiliev0 yiliev0 is a code owner

Assignees

@quiet-node quiet-node

Labels
enhancement New feature or request EVM evm related Tooling tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OZ erc1967upgrade example
2 participants
@quiet-node @Nana-EC