Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solidity Coverage - Signature example #533

Merged
merged 6 commits into from
Nov 10, 2023
Merged

Solidity Coverage - Signature example #533

merged 6 commits into from
Nov 10, 2023

Conversation

AlfredoG87
Copy link
Contributor

Description:

  • Adding test coverage for signature example and its tests,
  • Also fixed a typo on TypeOps tests

Related issue(s):

Fixes #492

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@github-actions
Copy link

github-actions bot commented Oct 26, 2023 •
edited
Loading

Test Results

196 tests  ±0   190 ✔️ +2   7m 17s ⏱️ -14s
  64 suites ±0       6 💤 ±0 
  14 files   ±0       0 ❌  - 2 

Results for commit ffd2a82. ± Comparison against base commit bf2ae26.

♻️ This comment has been updated with latest results.

Nana-EC
Nana-EC requested changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
2 suggestions

contracts/solidity/signature-example/ReceiverPays.sol Outdated Show resolved Hide resolved
test/constants.js Show resolved Hide resolved
@AlfredoG87 AlfredoG87 requested a review from Nana-EC November 7, 2023 20:54
Nana-EC
Nana-EC previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
Just fix the license on the contract

contracts/solidity/signature-example/ReceiverPays.sol Outdated Show resolved Hide resolved
@AlfredoG87 AlfredoG87 self-assigned this Nov 8, 2023
@AlfredoG87 AlfredoG87 added the enhancement New feature or request label Nov 8, 2023
@AlfredoG87 AlfredoG87 added this to the 0.7.0 milestone Nov 8, 2023
ebadiere
ebadiere previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

@AlfredoG87 AlfredoG87 force-pushed the 492-signature-example branch from 6ab7a62 to 07761c6 Compare November 9, 2023 03:19
Nana-EC
Nana-EC previously approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

AlfredoG87 and others added 6 commits November 9, 2023 15:35
@Nana-EC Nana-EC dismissed stale reviews from ebadiere and themself via ffd2a82 November 9, 2023 21:36
@Nana-EC Nana-EC force-pushed the 492-signature-example branch from 07761c6 to ffd2a82 Compare November 9, 2023 21:36
@Nana-EC Nana-EC requested a review from ebadiere November 10, 2023 01:17
ebadiere
ebadiere approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

@Nana-EC Nana-EC merged commit 3de889b into main Nov 10, 2023
20 of 21 checks passed
@Nana-EC Nana-EC deleted the 492-signature-example branch November 10, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebadiere ebadiere ebadiere approved these changes

@Nana-EC Nana-EC Nana-EC left review comments

@AleksandrinaAleksieva AleksandrinaAleksieva Awaiting requested review from AleksandrinaAleksieva

@georgi-l95 georgi-l95 Awaiting requested review from georgi-l95 georgi-l95 is a code owner

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov Ivo-Yankov is a code owner

@natanasow natanasow Awaiting requested review from natanasow natanasow is a code owner

@yiliev0 yiliev0 Awaiting requested review from yiliev0 yiliev0 is a code owner

Assignees

@AlfredoG87 AlfredoG87

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

[Solidity Support] Signature example
3 participants
@AlfredoG87 @ebadiere @Nana-EC