Adding tests for advance errors #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-stefanooov
requested review from
AlfredoG87,
AleksandrinaAleksieva,
ebadiere,
georgi-l95,
Ivo-Yankov,
natanasow,
yiliev0,
a team and
Nana-EC
as code owners
stefan-stefanooov
added
enhancement
Test Results 16 files + 2 81 suites +17 9m 51s ⏱️ + 2m 21s For more details on these failures, see this check. Results for commit 82534ce. ± Comparison against base commit 46ee829. ♻️ This comment has been updated with latest results. |
Nana-EC
requested changes
Oct 19, 2023
Signed-off-by: Stefan Stefanov <[email protected]>
Signed-off-by: Stefan Stefanov <[email protected]>
stefan-stefanooov
force-pushed
the
480-solidity-support-advanced-errors
branch
from
15781f9 to
0f4d2ab
Compare
Signed-off-by: Stefan Stefanov <[email protected]>
Nana-EC
approved these changes
Oct 23, 2023
| @@ -101,7 +101,6 @@ const Contract = { | |||
| ExchangeRateMock: 'ExchangeRateMock', | |||
| PrngSystemContract: 'PrngSystemContract', | |||
| Concatenation: 'Concatenation', | |||
| Errors: 'Errors', | |||
There was a problem hiding this comment.
This was already there so no need to remove it right?
It should conflict with other PRs
|
|
||
| const factory = await ethers.getContractFactory(Constants.Contract.Errors) | ||
| contract = await factory.deploy() | ||
| const factory = await ethers.getContractFactory('Errors') |
There was a problem hiding this comment.
Didn't need to change this as it's already in file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding tests for advance errors
Related issue(s):
#480