Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for the default values of all types in Solidity #497

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

stefan-stefanooov
Copy link
Contributor

Description:
Adding tests for the default values of all types in Solidity

Related issue(s):
#471

@stefan-stefanooov stefan-stefanooov added enhancement New feature or request P1 Limechain Items for Limechain team EVM evm related labels Oct 18, 2023
@stefan-stefanooov stefan-stefanooov added this to the 0.6.0 milestone Oct 18, 2023
@stefan-stefanooov stefan-stefanooov self-assigned this Oct 18, 2023
@stefan-stefanooov stefan-stefanooov linked an issue Oct 18, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Test Results

  16 files  +  3    68 suites  +6   8m 56s ⏱️ + 1m 16s
198 tests +  1  190 ✔️ ±  0  6 💤 ±0  2 +1 
218 runs  +21  210 ✔️ +20  6 💤 ±0  2 +1 

For more details on these failures, see this check.

Results for commit 670426c. ± Comparison against base commit 85a0600.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
Please add tag and ref for the not supported aspect

contracts/solidity/defaults/Defaults.sol Show resolved Hide resolved
test/solidity/defaults/defaults.js Outdated Show resolved Hide resolved
@stefan-stefanooov stefan-stefanooov force-pushed the 471-solidity-support-defaults-values branch from aec5dd4 to 6194691 Compare October 19, 2023 08:06
@stefan-stefanooov stefan-stefanooov force-pushed the 471-solidity-support-defaults-values branch from 8a78a50 to b553bc4 Compare October 20, 2023 06:42
Signed-off-by: Stefan Stefanov <[email protected]>
Signed-off-by: Stefan Stefanov <[email protected]>
Signed-off-by: Stefan Stefanov <[email protected]>
@stefan-stefanooov stefan-stefanooov force-pushed the 471-solidity-support-defaults-values branch from b553bc4 to f4216df Compare October 20, 2023 06:51
@@ -0,0 +1,108 @@
// SPDX-License-Identifier: UNLICENSED
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the license

@stefan-stefanooov stefan-stefanooov merged commit d6c28f5 into main Oct 23, 2023
20 of 21 checks passed
@stefan-stefanooov stefan-stefanooov deleted the 471-solidity-support-defaults-values branch October 23, 2023 12:23
@bibitibooo1 bibitibooo1 removed the Limechain Items for Limechain team label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EVM evm related P1
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Solidity Support] Defaults values
3 participants