Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Solidity Github action #469

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix Solidity Github action #469

merged 1 commit into from
Oct 17, 2023

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Oct 17, 2023

Description:
Github action for soldiity test is broken with bad yaml

  • encase test tag for fix yaml format
  • make action a workflow_call to have it run on call not automatically

Related issue(s):

Fixes #468

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Nana Essilfie-Conduah <[email protected]>
@Nana-EC Nana-EC requested a review from a team as a code owner October 17, 2023 01:59
@Nana-EC Nana-EC added this to the 0.6.0 milestone Oct 17, 2023
@Nana-EC Nana-EC added bug Something isn't working P2 labels Oct 17, 2023
@Nana-EC Nana-EC self-assigned this Oct 17, 2023
@Nana-EC Nana-EC requested review from ebadiere, AlfredoG87 and quiet-node and removed request for david-bakin-sl October 17, 2023 02:00
Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Test Results

  15 files  +  1    79 suites  +15   9m 21s ⏱️ + 2m 2s
198 tests ±  0  191 ✔️ ±  0  6 💤 ±0  1 ±0 
224 runs  +26  217 ✔️ +26  6 💤 ±0  1 ±0 

For more details on these failures, see this check.

Results for commit 7c4d0ca. ± Comparison against base commit b1a5fe1.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebadiere ebadiere merged commit 0b698b8 into main Oct 17, 2023
19 of 20 checks passed
@ebadiere ebadiere deleted the 468-fix-solidity-gh-action branch October 17, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solidity tests github action has bad yaml syntax
3 participants