Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added new test suite for PrngSystemContract (#416) #417

Merged
merged 4 commits into from
Sep 21, 2023

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented Sep 20, 2023

Description:
This PR adds a suite of unit test for PrngSystemContract and also adds it to CI

Related issue(s): #416

Fixes #416

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node linked an issue Sep 20, 2023 that may be closed by this pull request
@quiet-node quiet-node self-assigned this Sep 20, 2023
@quiet-node quiet-node added enhancement New feature or request P2 Tooling tooling labels Sep 20, 2023
@quiet-node quiet-node added this to the 0.6.0 milestone Sep 20, 2023
@github-actions
Copy link

github-actions bot commented Sep 20, 2023

Test Results

  16 files  +  4    94 suites  +35   10m 41s ⏱️ + 3m 17s
198 tests +11  190 ✔️ +11  6 💤 ±0  2 ±0 
250 runs  +63  241 ✔️ +62  6 💤 ±0  3 +1 

For more details on these failures, see this check.

Results for commit 60c16eb. ± Comparison against base commit 568fdc7.

♻️ This comment has been updated with latest results.

Nana-EC
Nana-EC previously approved these changes Sep 20, 2023
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.
One improvement

test/util-precompile/PrngSystemContract.js Show resolved Hide resolved
@quiet-node quiet-node merged commit 66ffc3a into main Sep 21, 2023
19 of 20 checks passed
@quiet-node quiet-node deleted the 416-add-prng-contract-tests branch September 21, 2023 16:08
mshakeg pushed a commit to mshakeg/hedera-smart-contracts that referenced this pull request Oct 14, 2023
…shgraph#417)

* test: added new test suite for PrngSystemContract

Signed-off-by: Logan Nguyen <[email protected]>

* test: added PrngSystemContract to CI tasks

Signed-off-by: Logan Nguyen <[email protected]>

* update(test): checked PseudoRandomSeed against HashZero

Signed-off-by: Logan Nguyen <[email protected]>

* update: added expect(result).to.exist

Signed-off-by: Logan Nguyen <[email protected]>

---------

Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Mo Shaikjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Tooling tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PRNG contract tests
2 participants