Add network info subcomponent needed for the state #9673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kristiyan Selveliev <[email protected]>
kselveliev
requested review from
bilyana-gospodinova,
IvanKavaldzhiev and
nickeynikolovv
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9673 +/- ##
============================================
+ Coverage 92.21% 92.33% +0.11%
+ Complexity 7609 7511 -98
============================================
Files 932 916 -16
Lines 31940 31751 -189
Branches 4029 4020 -9
============================================
- Hits 29455 29316 -139
+ Misses 1535 1490 -45
+ Partials 950 945 -5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kristiyan Selveliev <[email protected]>
Signed-off-by: Kristiyan Selveliev <[email protected]>
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/NetworkInfoImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <[email protected]>
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/NetworkInfoImpl.java
Show resolved
Hide resolved
Signed-off-by: Kristiyan Selveliev <[email protected]>
|
steven-sheehy
changed the title
steven-sheehy
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR add NetworkInfo component needed for the state of the reusable services code
This PR modifies ... in order to support ...
Add NetworkInfoImpl class similar to services
Add NetworkInfoImplTest
Related issue(s):
Partially closes #9260
Fixes #
Notes for reviewer:
Checklist