-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add workaround for support of isAssociated #2828
feat: Add workaround for support of isAssociated #2828
Conversation
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Eric Badiere <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Some comments in-line.
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG.
Signed-off-by: Ivo Yankov <[email protected]>
Signed-off-by: Ivo Yankov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2828 +/- ##
==========================================
+ Coverage 84.25% 84.32% +0.07%
==========================================
Files 40 56 +16
Lines 3055 3771 +716
Branches 632 771 +139
==========================================
+ Hits 2574 3180 +606
- Misses 279 353 +74
- Partials 202 238 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description:
isAssociated
calls to the relay.ETH_CALL_FORCE_TO_CONSENSUS_BY_SELECTOR
that enables some requests toeth_call
to go through the Consensus node instead of the Mirror node regardless of the value ofETH_CALL_DEFAULT_TO_CONSENSUS_NODE
. When set totrue
if the function selector is found in a predetermined array then the call will go through Consensus. For now the only entry in this list is0x4d8fdd6d
, which is the selector ofisAssociated()
Related issue(s):
Fixes #2810
Notes for reviewer:
Checklist