Update transaction.js #3252
Merged
Update transaction.js #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this.header_pos was tested for zero on the previous line (148) so at this point (155), it would contain a number greater than zero and doesn't need to be tested again..
msimerson
approved these changes
Dec 3, 2023
msimerson
added a commit
that referenced
this pull request
Feb 8, 2024
### [3.0.3] - 2024-02-07 #### Added - feat(auth_vpopmaild): when outbound, assure the envelope domain matches AUTH domain #3265 - docs(outbound): remove example setting outbound_ip #3253 - doc(Plugins.md): add pi-queue-kafka #3247 - feat(rabbitmq_amqplib): configurable optional queue arguments #3239 - feat(clamd): add x-haraka-virus header #3207 #### Fixed - Fix: add empty string as param to .join() on bounce. #3237 - Update links in documentation #3234 - fix(ob/hmail):Add filename to the error for easy debugging - fix(ob/queue): Ignore 'error.' prefixed files in the queue because corrupted #### Changed - docs(outbound): remove example of outbound_ip #3253 - transaction: simplify else condition in add_data #3252 - q/smtp_forward: always register get_mx hook #3204 - dep(pi-es): bump version to 8.0.2 #3206 - dep(redis): bump version to 4.6.7 #3193 - dep(pi-spf): bump version to 1.2.4 - dep(net-utils): bump version to 1.5.3 - dep(pi-redis): bump version to 2.0.6 - dep(tld): bump version to 1.2.0 - remove defunct config files: lookup_rdns.strict.ini, lookup_rdns.strict.timeout, lookup_rdns.strict.whitelist, lookup_rdns.strict.whitelist_regex, rcpt_to.blocklist, rdns.allow_regexps, rdns.deny_regexps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.header_poswas tested for zero on the previous line (148) so at this point (155), it would contain a number greater than zero and doesn't need to be tested again..Changes proposed in this pull request:
this.header_pos