Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: Allow custom properties on output.payload #279

Merged
merged 1 commit into from
Dec 16, 2020
Merged

TypeScript: Allow custom properties on output.payload #279

merged 1 commit into from
Dec 16, 2020

Conversation

watson
Copy link
Contributor

@watson watson commented Dec 15, 2020

Fixes #277

@watson watson mentioned this pull request Dec 15, 2020
Closed
@Nargonath Nargonath added the types TypeScript type definitions label Dec 16, 2020
Nargonath
Nargonath approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@Nargonath Nargonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nargonath Nargonath added this to the 9.1.1 milestone Dec 16, 2020
@Nargonath Nargonath added the bug Bug or defect label Dec 16, 2020
kanongil
kanongil approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@kanongil kanongil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a non-breaking type fix.

@Nargonath Nargonath self-assigned this Dec 16, 2020
@Nargonath Nargonath merged commit 3a6e4e7 into hapijs:master Dec 16, 2020
@watson watson deleted the any-payload branch December 16, 2020 11:40
@dependabot dependabot bot mentioned this pull request Mar 8, 2021
Closed
This was referenced Mar 16, 2021
Closed
Closed
@renovate renovate bot mentioned this pull request May 21, 2021
Merged
1 task
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
@doron2402 doron2402 mentioned this pull request Feb 6, 2024
Open
@nscando nscando mentioned this pull request Sep 7, 2024
Open
@rodcko rodcko mentioned this pull request Sep 10, 2024
Open
@beclamide beclamide mentioned this pull request Sep 19, 2024
Closed
@doperiddle doperiddle mentioned this pull request Nov 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanongil kanongil kanongil approved these changes

@Nargonath Nargonath Nargonath approved these changes

Assignees

@Nargonath Nargonath

Labels
bug Bug or defect types TypeScript type definitions
Projects
None yet
Milestone
9.1.1
Development

Successfully merging this pull request may close these issues.

output.payload.attributes is not exposed in the .d.ts file
3 participants
@watson @Nargonath @kanongil