Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arrow down navigation on touch devices #2410

Merged
merged 1 commit into from
May 27, 2019
Merged

Fix arrow down navigation on touch devices #2410

merged 1 commit into from
May 27, 2019

Conversation

NoriSte
Copy link
Contributor

@NoriSte NoriSte commented May 18, 2019

Some users reported me that the arrow down doesn't work on touch devices. They found that the arrow down brings them to the last slide sometimes.

After some investigations, I and @Ir0nsides have realized that it's not a bug per se, it's just a usability problem. There is a (too much) subtle space between the arrows and the progress bar that, on a touch device, make the user tap on the progress bar instead of on the arrow.

What we have done: we augmented the sensible area of the arrow down to avoid this kind of problems. It, obviously, make impossible to jump straight to the last slide when touching the progress bar (if the down arrow is visible), but try the current version on a touch device to realize how much is the current behavior annoying.

Open Source Saturday
I'd like to spread some love for the Open Source Saturday meetups, a series of events where the only goal is to contribute to OSS ❤️

@NoriSte NoriSte closed this May 18, 2019
@NoriSte NoriSte reopened this May 18, 2019
@hakimel hakimel changed the base branch from master to dev May 27, 2019 05:53
@hakimel hakimel merged commit 9108519 into hakimel:dev May 27, 2019
@hakimel
Copy link
Owner

hakimel commented May 27, 2019

Thanks for the PR! I ran into this issue the other day too and I'm sure many others have as well.

@NoriSte NoriSte deleted the feature/fix-touch-arrow-down branch May 27, 2019 12:43
@denehyg
Copy link
Contributor

denehyg commented Jun 2, 2019

Hey @hakimel, I submitted PR #2142 a while back to implement a passive option for the progress bar for the same issue. It’s not just the down arrow that’s the issue. If there’s interactive content near the bottom, eg full slide data viz, it can be triggered from anywhere along the progress bar. A passive option would avoid this.

@NoriSte
Copy link
Contributor Author

NoriSte commented Jun 3, 2019

I think that @denehyg should be merged too, it solves a more generic problem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants