notes plugin: callRevealApi wants apply, not call #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djsutherland
added a commit
to djsutherland/reveal.js-notes-pointer
that referenced
this pull request
Mar 12, 2019
|
Good catch. Thanks! |
R0bes
pushed a commit
to R0bes/Terraform-Presentation
that referenced
this pull request
Jun 7, 2021
notes plugin: callRevealApi wants apply, not call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
callRevealApi()function introduced in #2104, which takesmethodArgumentswhich is clearly supposed to be a list, was passing that list as the first argument to the given function. This didn't really matter, because it's currently only ever called with[]and for functions that don't actually take any arguments, but it broke things in my #2337 that introduces an argument togetSlidesPastCount.