Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the SegTree and LazySegTree with open ended ranges #24

Merged
merged 4 commits into from
Sep 7, 2023

Conversation

ngng628
Copy link
Contributor

@ngng628 ngng628 commented Sep 3, 2023

  • Tests pass
  • Appropriate changes to README are included in PR

Overview

  • 標準ライブラリに合わせて Range で open ended ranges に対応させました。
    • tree[..3]
    • tree[1..]
    • tree[...]

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2023

Codecov Report

Merging #24 (3a9f365) into master (2832b71) will increase coverage by 0.27%.
The diff coverage is 100.00%.

❗ Current head 3a9f365 differs from pull request most recent head a95ccb8. Consider uploading reports for the commit a95ccb8 to get more accurate results

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   81.95%   82.23%   +0.27%     
==========================================
  Files          14       14              
  Lines        1092     1092              
==========================================
+ Hits          895      898       +3     
+ Misses        197      194       -3     
Files Changed Coverage Δ
src/lazy_seg_tree.cr 85.61% <100.00%> (+1.43%) ⬆️
src/seg_tree.cr 82.35% <100.00%> (+1.17%) ⬆️

@ngng628 ngng628 changed the title Add support for the SegTree#sum and LazySegTree#sum with open ended ranges Add support for the SegTree and LazySegTree with open ended ranges Sep 4, 2023
Copy link
Owner

@hakatashi hakatashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

変更内容は良さそうです!

  • ユニットテストを追加してください
  • masterのほうをいじったのでrebaseかmergeをお願いします

@ngng628
Copy link
Contributor Author

ngng628 commented Sep 6, 2023

変更内容は良さそうです!

  • ユニットテストを追加してください
  • masterのほうをいじったのでrebaseかmergeをお願いします

追加しました!

Copy link
Owner

@hakatashi hakatashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@hakatashi hakatashi merged commit 0fe07c4 into hakatashi:master Sep 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants