Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denote which tab is clicked in Nav Bar #174

Open
Aghassi opened this issue Oct 23, 2015 · 6 comments
Open

Denote which tab is clicked in Nav Bar #174

Aghassi opened this issue Oct 23, 2015 · 6 comments

Comments

@Aghassi
Copy link

Aghassi commented Oct 23, 2015

Right now, it is a tad confusing which tab a user is in when browsing the site. The tab should remained clicked or "indented" so I know which tab I am in. Also, I find it weird that the "Get Jolly" title and the "Explorer" tab both lead to the same page. Pedantic, but figured I should say something.

@ajm188
Copy link
Member

ajm188 commented Oct 23, 2015

Do you want to work on this? If so, I'll leave you to it. If not, it will get done ... eventually.

@Aghassi
Copy link
Author

Aghassi commented Oct 23, 2015

@ajm188 I should bite my tongue in the future. I'm not a ruby dev, and looking through the source I have no idea what manages the actual nav-bar. I see the HAML file where it is generated, but beyond that I'm sort of lost. I'll probably play around with it in my free time, but the time it will get done by is probably on the same time scale as eventually

@ajm188
Copy link
Member

ajm188 commented Oct 23, 2015

Actually, I'm glad you didn't. We need people actually using this and submitting issues. The problem is I don't have much time to devote to this, and I don't think many others are actively working on it.

As for the actual changes this requires, you can probably work exclusively in the haml files. The only "ruby" thing (it's actually a rails thing), you might need is link_to, which creates links pretty much as you would expect. Docs here.

@StephHippo
Copy link
Member

This Stack Overflow question should answer what you want to aim for our project. I'm happy to talk you through it if you just want to ping me after work some time.
http://stackoverflow.com/questions/829727/highlight-tab-in-menu

@Aghassi
Copy link
Author

Aghassi commented Nov 4, 2015

@StephHippo I'd love to, but this weekend or next week would be better for me. I have a lot of work on my plate at the moment.

@StephHippo
Copy link
Member

Any time. That was meant to be more of an open-ended invitation. :)

@ajm188 ajm188 self-assigned this May 12, 2016
ajm188 pushed a commit that referenced this issue May 12, 2016
@ajm188 ajm188 added this to the OSS Sprint milestone Aug 19, 2016
@ajm188 ajm188 removed their assignment Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants