Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.60 #14

Merged
merged 3 commits into from
Nov 7, 2022
Merged

Bump MSRV to 1.60 #14

merged 3 commits into from
Nov 7, 2022

Conversation

h3r2tic
Copy link
Owner

@h3r2tic h3r2tic commented Nov 7, 2022

Needed for bytemuck: Lokathor/bytemuck#140 (comment)

README.md Outdated
@@ -1,103 +1,103 @@
# 🎥 dolly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure that you didn't want to change this entire file to CRLF!

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WHAT IN THE... ARGH. Thanks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Windows things™? 😬

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup... Had autocrlf disabled due to some recent issues when running shell scripts from a Linux container inside a repo synced on Windows... CRLF is a gift that keeps on giving.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phew, fixed. Using the classic method of "screw everything, re-download the file from main, and apply fixes on top".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSYS2?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git 👀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git-for-windows is effectively MSYS2 with changes / preincluded packages / optimized git package specifically for Windows.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 😂 😂 😂

@h3r2tic h3r2tic merged commit b947326 into main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants