Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tag): 🚀 add new prop ellipsis for large texts on tag #646

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

Dario-Felipe
Copy link
Contributor

Description 📄

  • It was added a new prop to <Tag /> component, called ellipsis, that will work together maxWidth prop to put, if needs, some ellipsis for large texts.
  • With this feature the<Tag /> component start to accept maxWidth prop too;

This issue was looked by vms team, because one of ours features needs Tag component and some texts are too large, so was needed put ellipsis to hide their.

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

Default Tag:

image

Informative Tag:

image

@matheushdsbr matheushdsbr merged commit 6897879 into gympass:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants