Rex DrawState: Fix crash from accessing possible null. #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one of the programs (e.g. HexTiler) fails to compile, it's possible to get
_pcpas null. This patch fixes the immediate crash from that behavior. The globe still isn't shown in that case, but at least the software doesn't segfault immediately.I know this is an unexpected case of null
_pcp. I'd rather fix the root cause but since it looks like this can happen from a bad glsl, it might be easily triggered, so there should be some protection. I'm still looking for/at the root cause in the shader, it's something in the new Hex Tile stuff.