Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates JIRA API REST login credentials #73

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

alefq
Copy link

@alefq alefq commented Oct 11, 2019

username/password are no longer valid credentials. E-mail and API_TOKEN are required to access REST API.

alefq added 2 commits October 11, 2019 12:53
`username/password` are no longer valid credentials. E-mail and API_TOKEN are required to access REST API.
@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #73 into master will decrease coverage by 20.93%.
The diff coverage is 22.76%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #73       +/-   ##
=============================================
- Coverage     88.12%   67.18%   -20.94%     
- Complexity      208      242       +34     
=============================================
  Files            39       44        +5     
  Lines           522      765      +243     
  Branches         35       78       +43     
=============================================
+ Hits            460      514       +54     
- Misses           40      225      +185     
- Partials         22       26        +4     
Impacted Files Coverage Δ Complexity Δ
...cketchat/jira_trigger/routes/DetectIssueRoute.java 68.88% <ø> (ø) 7.00 <0.00> (ø)
...chat/jira_trigger/server/JiraServerInfoLogger.java 85.71% <ø> (ø) 3.00 <0.00> (ø)
...cketchat/jira_trigger/validation/BotValidator.java 50.00% <0.00%> (-30.00%) 3.00 <2.00> (+1.00) ⬇️
...models/from_rocket_chat/FromRocketChatMessage.java 13.04% <13.04%> (ø) 8.00 <8.00> (?)
.../models/to_rocket_chat/ToRocketChatAttachment.java 21.34% <21.34%> (ø) 12.00 <12.00> (?)
...rlsson/rocketchat/models/to_rocket_chat/Field.java 25.00% <25.00%> (ø) 3.00 <3.00> (?)
...hat/models/to_rocket_chat/ToRocketChatMessage.java 27.27% <27.27%> (ø) 7.00 <7.00> (?)
...ocketchat/spark/routes/RocketChatMessageRoute.java 56.25% <56.25%> (ø) 3.00 <3.00> (?)
...tchat/jira_trigger/messages/AttachmentCreator.java 86.36% <100.00%> (ø) 15.00 <1.00> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f948daf...6c4fb45. Read the comment docs.

@gustavkarlsson
Copy link
Owner

Have you tried this? Substituting username and password with email and API key just works out of the box?

@alefq
Copy link
Author

alefq commented Oct 11, 2019

Yes, on working installation tested it with new credentials, worked out of the box.
rocket-jira

Ale Feltes and others added 3 commits May 26, 2020 13:13
- Fixes Rocket chat 3.0.12 responses boolean or an object for "bot"
property.
- Eliminates dependencies that only had 1 class on them.
Updates libraries to work with latest Jira API REST (v3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants