Improved Dockerfile:

[Crazy-Hopper]

• utilized stage build which results in much smaller result image;
• removed unneeded VOLUME declaration;
• copied default configuration file into result image into /app/etc;
• symlinked /app/config.toml to /app/etc/config.toml for backward
  compatibility.

[codecov]

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #62   +/-   ##
=========================================
  Coverage     88.12%   88.12%           
  Complexity      208      208           
=========================================
  Files            39       39           
  Lines           522      522           
  Branches         35       35           
=========================================
  Hits            460      460           
  Misses           40       40           
  Partials         22       22

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cd5c22...9d961e6. Read the comment docs.

[gustavkarlsson]

Thanks for contributing!

A few things:

• Looks a lot cleaner, and I learned something about multi staged builds! But...
• How is the resulting image smaller? I tried building with and without your changes and they both ended up at 640MB...
• The "default configuration file" is not a valid config file in itself so it can't be used as as suggested

[igortg]

How is the resulting image smaller? I tried building with and without your changes and they both ended up at 640MB...

I'd guess that most of the size is openjdk image's fault. So no point in doing multi-stage build. I'd remove it.

The "default configuration file" is not a valid config file in itself so it can't be used as as suggested

There's no way of setting a "default configuration file" that would work (unless you get a demo JIRA instance that we can point to). By adding a default config file, at least we would not get the current "/app/config.toml do not exists" error when starting the container without -v option.

The removal of the VOLUME line is the most important part of this PR, since right now it's not possible to use docker config or docker secret (which are more fit for config stuff) to set the service configuration. What about removing the multi-stage code and merge this?

And by the way, great work. Very useful integration.