Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata document Quality Thread #169

Open
lumjjb opened this issue Oct 20, 2022 · 4 comments
Open

Metadata document Quality Thread #169

lumjjb opened this issue Oct 20, 2022 · 4 comments
Labels
long-term Things for the future

Comments

@lumjjb
Copy link
Contributor

lumjjb commented Oct 20, 2022

This issue keeps track of data quality and parsing metadata documents. If there are issues processing certain documents, do let us know and provide an example document that we can test with.

  1. Type of Document:
  2. Exhibited behavior (error, missing info, etc.):
  3. Expected behavior:
  4. Link to metadata document:
  5. Link to relevant issues:
@electricgull
Copy link

electricgull commented Nov 3, 2022

  1. CycloneDX
  2. segfault when running against a CycloneDx 1.3 bom
  3. no error and ingests the data.
  4. https://github.com/JupiterOne/graph-github/blob/guac-bom-test-cg/reports/bom.json

How to reproduce

git clone [email protected]:JupiterOne/graph-github.git
cd graph-github
docker run --rm -v ${PWD}/src jupiterone/node-cdx-bom:latest '/src/reports/bom.json'
../guacsec/guac/bin/guacone files --creds neo4j:s3cr3t reports/

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x68 pc=0x1978521]

Let me know if additional information is needed.

MAINTAINER EDIT: Fixed by #207

@nadgowdas
Copy link
Contributor

thanks for reporting, let me check!

@cklim24

This comment was marked as spam.

@nchelluri
Copy link
Contributor

nchelluri commented Apr 24, 2024

  1. SPDX
  2. If a relationships value is null, then the upstream SPDX parser will panic
  3. The upstream parser should not panic, and the relationship in question would not be created
  4. spdx-null-rel.json
  5. Saw this when implementing a fix for [ingestion/data-quality issue] An SPDX JSON SBOM with a bad relationships value will cause a nil pointer dereference panic #1821 . I have now filed Nil ptr deref panic when parsing JSON SBOM with a null relationships value spdx/tools-golang#238 .

desmax74 pushed a commit to desmax74/guacsec-guac that referenced this issue Nov 21, 2024
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
long-term Things for the future
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants