Update sourcemap.js #130
Merged
Update sourcemap.js #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR solves #144. |
Closed
stefan--
pushed a commit
to stefan--/grunt-contrib-concat
that referenced
this pull request
Dec 11, 2015
|
@vladikoff Would you be able to bump the version so that I can pull this into my project? I'm experiencing the same bug during sourcemap creation and this patch solves it. I just have to manually edit the concat library file right now. Thanks for any help. |
|
This broke again since Browserify changed from "charset:" to "charset=". Wtf, guys. I fixed it by changing the regex to allow an arbitrary character in that position: This whole code just feels way too brittle, but I don't even know if there is an official specification for what is valid after |
alexjking
added a commit
to alexjking/grunt-contrib-concat
that referenced
this pull request
Feb 22, 2017
Browserify has changed the sourcemap charset to use `=` instead of `:`. This has frequently changed, so this fix changes the regex to match a single character `.` For reference: https://github.com/substack/node-browserify/blob/b2374cef35072e7690ab31a68664b0733c1b4995/changelog.markdown#1200 Fixes gruntjs#130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
browserify with debug:true stores a sourcemap at the end of the file as a datauri
sometimes the datauri is prefixed with "data:application/json;base64," and sometimes with
data:application/json;charset:utf-8;base64,changed the regexp at line 112 to account for the difference